Attention is currently required from: Tim Wawrzynczak, Jingle Hsu, Angel Pons, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58576 )
Change subject: soc/intel/common: Add DDR5 and LPDDR5 into the SMBIOS table
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/smbios.c:
https://review.coreboot.org/c/coreboot/+/58576/comment/76a73cde_cca3ebd3
PS1, Line 84: dimm->bus_width |= 0x10;
Oops yes I guess we want an smbios_spd_width_to_bus_width instead ;)
Tim, we don't need new API as smbios_bus_width_to_spd_width() should be enough to assign dimm->bus_width as per its comments.
Can you please take a look into https://review.coreboot.org/c/coreboot/+/58655
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58576
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ec442cf0bd830db99e3636445724b6be01c5564
Gerrit-Change-Number: 58576
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 27 Oct 2021 17:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment