Attention is currently required from: Tarun Tuli, Caveh Jalali, Christian Walter, Nick Vaccaro, Daisuke Nojiri, Eric Lai, Boris Mittelberg.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70773 )
Change subject: chromeos/cr50_enable_update.c: Clear EC AP_IDLE flag
......................................................................
Patch Set 16:
(2 comments)
File src/ec/google/chromeec/ec_commands.h:
PS16:
we should really have a separate patch to refresh ec_commands.h from […]
Agree, I will submit a separate patch to refresh ec_commands.h from EC repo.
File src/vendorcode/google/chromeos/cr50_enable_update.c:
https://review.coreboot.org/c/coreboot/+/70773/comment/91f42c0e_c63ff6bc
PS16, Line 79: printk(BIOS_INFO, "Successfully clear AP_IDLE flag");
do we need success msg always or just able to catch the failure case is fine?
I prefer to print success msg so that we can know if the function is called or no.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If97ffbe65f4783f17f4747a87b0bf89a2b021a3b
Gerrit-Change-Number: 70773
Gerrit-PatchSet: 16
Gerrit-Owner: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Mon, 09 Jan 2023 02:07:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment