Change in coreboot[master]: soc/intel/skylake: Configure TraceHub options only if it's is enabled
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44033 )
Change subject: soc/intel/skylake: Configure TraceHub options only if it's is enabled ......................................................................
soc/intel/skylake: Configure TraceHub options only if it's is enabled
Change-Id: Icea4d235e159f2ebeb9c0e3ce72c07139893a91b Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/soc/intel/skylake/romstage/romstage.c 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44033/1
diff --git a/src/soc/intel/skylake/romstage/romstage.c b/src/soc/intel/skylake/romstage/romstage.c index 76f7a73..c84a309 100644 --- a/src/soc/intel/skylake/romstage/romstage.c +++ b/src/soc/intel/skylake/romstage/romstage.c @@ -296,8 +296,10 @@
dev = pcidev_path_on_root(PCH_DEVFN_TRACEHUB); m_cfg->EnableTraceHub = dev ? dev->enabled : 0; - m_cfg->TraceHubMemReg0Size = config->TraceHubMemReg0Size; - m_cfg->TraceHubMemReg1Size = config->TraceHubMemReg1Size; + if (!m_cfg->EnableTraceHub) { + m_cfg->TraceHubMemReg0Size = config->TraceHubMemReg0Size; + m_cfg->TraceHubMemReg1Size = config->TraceHubMemReg1Size; + }
/* Enable SMBus controller */ dev = pcidev_path_on_root(PCH_DEVFN_SMBUS);
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44033
to look at the new patch set (#2).
Change subject: soc/intel/skylake: Configure TraceHub options only if it's enabled ......................................................................
soc/intel/skylake: Configure TraceHub options only if it's enabled
Change-Id: Icea4d235e159f2ebeb9c0e3ce72c07139893a91b Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/soc/intel/skylake/romstage/romstage.c 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44033/2
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44033
to look at the new patch set (#3).
Change subject: soc/intel/skylake: Configure TraceHub options only if it's enabled ......................................................................
soc/intel/skylake: Configure TraceHub options only if it's enabled
Change-Id: Icea4d235e159f2ebeb9c0e3ce72c07139893a91b Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/soc/intel/skylake/romstage/romstage.c 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44033/3
-
Felix Singer (Code Review)