Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76015?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for ScsSdCardWpPinEnabled dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for ScsSdCardWpPinEnabled dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="ScsSdCardWpPinEnabled" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: Idd3731ab878c1023028c8a482b16583612e5aa84 Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/puff/variants/baseboard/devicetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/76015/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 1866bd1..e77da3b 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -45,7 +45,7 @@ # Unlock GPIO pads register "PchUnlockGpioPads" = "1" # SD card WP pin configuration - register "ScsSdCardWpPinEnabled" = "0" + register ScsSdCardWpPinEnabled = false
# NOTE: if any variant wants to override this value, use the same format # as register "common_soc_config.pch_thermal_trip" = "value", instead of diff --git a/src/mainboard/google/puff/variants/baseboard/devicetree.cb b/src/mainboard/google/puff/variants/baseboard/devicetree.cb index 7e9e2a6..3f7b503 100644 --- a/src/mainboard/google/puff/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/puff/variants/baseboard/devicetree.cb @@ -45,7 +45,7 @@ # Unlock GPIO pads register "PchUnlockGpioPads" = "1" # SD card WP pin configuration - register "ScsSdCardWpPinEnabled" = "0" + register ScsSdCardWpPinEnabled = false
# NOTE: if any variant wants to override this value, use the same format # as register "common_soc_config.pch_thermal_trip" = "value", instead of