Change in coreboot[master]: ec/lenovo/h8: Prepend EC log message with *H8* - coreboot-gerrit

List overview All Threads
Download

newer

Change in coreboot[master]: ec/lenovo/h8: Prepend EC log message with H8

older

Change in coreboot[master]:...

Paul Menzel (Code Review)

9 Jan 2020 9 Jan '20

10:44 p.m.

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38312 )

Change subject: ec/lenovo/h8: Prepend EC log message with *H8* ......................................................................

ec/lenovo/h8: Prepend EC log message with *H8*

All other messages in `ec/lenovo/h8` are prepended with *H8*, so also prepend the EC version log message with *H8*.

EC Firmware ID 79HT50WW-3.4, Version 7.01A No CMOS option 'usb_always_on'. H8: BDC detection not implemented. Assuming BDC installed H8: WWAN detection not implemented. Assuming WWAN installed No CMOS option 'fn_ctrl_swap'.

Change-Id: Ib4f341946a336b57bd96c053a05364276caad1ac Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/ec/lenovo/h8/h8.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/38312/1

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index 73657bc..ed46a3f 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -106,7 +106,7 @@ fwvh = ec_read(0xe9); fwvl = ec_read(0xe8);

- printk(BIOS_INFO, "EC Firmware ID %s, Version %d.%d%d%c\n", ecfw, + printk(BIOS_INFO, "H8: EC Firmware ID %s, Version %d.%d%d%c\n", ecfw, fwvh >> 4, fwvh & 0x0f, fwvl >> 4, 0x41 + (fwvl & 0xf)); }

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Angel Pons (Code Review)

10 Jan 10 Jan

12:49 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38312 )

Change subject: ec/lenovo/h8: Prepend EC log message with *H8* ......................................................................

Patch Set 1:

I wonder how that works out with the xx30 Thinkpads. They don't have any H8 EC, but rather a different SMSC MEC1609 (?) EC :D

-- To view, visit https://review.coreboot.org/c/coreboot/+/38312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4f341946a336b57bd96c053a05364276caad1ac Gerrit-Change-Number: 38312 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Thu, 09 Jan 2020 23:49:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

2:05 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38312 )

Change subject: ec/lenovo/h8: Prepend EC log message with *H8* ......................................................................

Patch Set 1:

...

Patch Set 1:

I wonder how that works out with the xx30 Thinkpads. They don't have any H8 EC, but rather a different SMSC MEC1609 (?) EC :D

Sorry, I do not know the code well enough. The function name is `h8_log_ec_version()`, so I miss the connection.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4f341946a336b57bd96c053a05364276caad1ac Gerrit-Change-Number: 38312 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 10 Jan 2020 13:05:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

2:32 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38312 )

Change subject: ec/lenovo/h8: Prepend EC log message with *H8* ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4f341946a336b57bd96c053a05364276caad1ac Gerrit-Change-Number: 38312 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 10 Jan 2020 13:32:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Alexander Couzens (Code Review)

13 Jan 13 Jan

1:24 a.m.

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38312 )

Change subject: ec/lenovo/h8: Prepend EC log message with *H8* ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4f341946a336b57bd96c053a05364276caad1ac Gerrit-Change-Number: 38312 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Mon, 13 Jan 2020 00:24:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Alexander Couzens (Code Review)

1:35 a.m.

Alexander Couzens has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38312 )

Change subject: ec/lenovo/h8: Prepend EC log message with *H8* ......................................................................

ec/lenovo/h8: Prepend EC log message with *H8*

All other messages in `ec/lenovo/h8` are prepended with *H8*, so also prepend the EC version log message with *H8*.

Change-Id: Ib4f341946a336b57bd96c053a05364276caad1ac Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/38312 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Alexander Couzens lynxis@fe80.eu --- M src/ec/lenovo/h8/h8.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Alexander Couzens: Looks good to me, approved Patrick Rudolph: Looks good to me, approved

- printk(BIOS_INFO, "EC Firmware ID %s, Version %d.%d%d%c\n", ecfw, + printk(BIOS_INFO, "H8: EC Firmware ID %s, Version %d.%d%d%c\n", ecfw, fwvh >> 4, fwvh & 0x0f, fwvl >> 4, 0x41 + (fwvl & 0xf)); }

-- To view, visit https://review.coreboot.org/c/coreboot/+/38312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4f341946a336b57bd96c053a05364276caad1ac Gerrit-Change-Number: 38312 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: merged

9elements QA (Code Review)

1:47 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38312 )

Change subject: ec/lenovo/h8: Prepend EC log message with *H8* ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : No test failed. EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : No test failed. EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : No test failed.

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/38312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4f341946a336b57bd96c053a05364276caad1ac Gerrit-Change-Number: 38312 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Mon, 13 Jan 2020 00:47:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1578

days inactive

1582

days old

coreboot-gerrit@coreboot.org

6 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Alexander Couzens (Code Review)
Angel Pons (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)