Change in coreboot[master]: console/post: NOPOST means NOPOST.

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38408 )

Change subject: console/post: NOPOST means NOPOST.
......................................................................

console/post: NOPOST means NOPOST.

Not "NOPOST except when the board says something else".

Change-Id: I3608e9c3a7d2338363a4320c8718b20ef25a038a
Signed-off-by: Patrick Georgi 
---
M src/console/post.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/38408/1

diff --git a/src/console/post.c b/src/console/post.c
index 33d85e7..6265770 100644
--- a/src/console/post.c
+++ b/src/console/post.c
@@ -32,6 +32,7 @@

if (CONFIG(CONSOLE_POST))
    		printk(BIOS_EMERG, "POST: 0x%02x\n", value);
+
+		mainboard_post(value);
    }
-	mainboard_post(value);
 }

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38408 )

Change subject: console/post: NOPOST means NOPOST.
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38408/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38408/1//COMMIT_MSG@7 
PS1, Line 7: .
trailing period, though it helps make the statement sound more condescending.

Change in coreboot[master]: console/post: NOPOST means NOPOST

[Patrick Georgi (Code Review)]

Hello Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38408

to look at the new patch set (#2).

Change subject: console/post: NOPOST means NOPOST
......................................................................

console/post: NOPOST means NOPOST

Not "NOPOST except when the board says something else".

Change-Id: I3608e9c3a7d2338363a4320c8718b20ef25a038a
Signed-off-by: Patrick Georgi 
---
M src/console/post.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/38408/2

Change in coreboot[master]: console/post: NOPOST means NOPOST

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38408 )

Change subject: console/post: NOPOST means NOPOST
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38408/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38408/1//COMMIT_MSG@7 
PS1, Line 7: .
> trailing period, though it helps make the statement sound more condescending.

Done

Change in coreboot[master]: console/post: NOPOST means NOPOST

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38408 )

Change subject: console/post: NOPOST means NOPOST
......................................................................

console/post: NOPOST means NOPOST

Not "NOPOST except when the board says something else".

Change-Id: I3608e9c3a7d2338363a4320c8718b20ef25a038a
Signed-off-by: Patrick Georgi 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38408
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/console/post.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/console/post.c b/src/console/post.c
index 33d85e7..6265770 100644
--- a/src/console/post.c
+++ b/src/console/post.c
@@ -32,6 +32,7 @@

if (CONFIG(CONSOLE_POST))
    		printk(BIOS_EMERG, "POST: 0x%02x\n", value);
+
+		mainboard_post(value);
    }
-	mainboard_post(value);
 }