Attention is currently required from: Arthur Heymans, Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel, Zheng Bao.
Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75405?usp=email )
Change subject: soc/amd/smm: Check the SMM TSEG size
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75405/comment/d0f75c7d_a317ab10 :
PS3, Line 10: The SMM TSEG size should be less than SMM reserved size, bigger than
: 8M, and power of 2.
For a number, it is a power of 2 AND it is bigger than 8M, it is 8M, 16M, 32M, ...
Does it have a "granularity of 128K"?
granularity 128K mean it needs to be larger than 128K and a power of 2.
+1, As per AMD64 Architecture Progrmamer's Manual, Section 10.2.5 SMRAM Protected Areas:
`The TSeg range must be aligned to a 128 Kbyte boundary and the minimum TSeg
size is 128 Kbytes.`
But is Bao Zheng trying to put an extra sanity check here to ensure expected size to be greater than equal to 8Mib for some reason?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75405?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4f557c7b77db6fc5ab2783ca4e2ebe7a4476e85
Gerrit-Change-Number: 75405
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 02 Jun 2023 12:31:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment