Change in ...coreboot[master]: soc/intel/common: Increase SMM_MODULE_STACK stack to 0x800
Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33999
Change subject: soc/intel/common: Increase SMM_MODULE_STACK stack to 0x800 ......................................................................
soc/intel/common: Increase SMM_MODULE_STACK stack to 0x800
While running the s0ix cycling test, we observed SMM Handler caused a stack overflow. This error happens during event log access.
This change is to increase the SMM_MODULE_STACK size to 0x800
BUG=b:135551854 TEST=suspend_resume test pass 500+ cycles, originally issue happenes within 150 cycle
Change-Id: Ib4686b4d2d4fc3976068779314f4ee15ef4a8ae2 Signed-off-by: Kane Chen kane.chen@intel.com --- M src/soc/intel/common/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/33999/1
diff --git a/src/soc/intel/common/Kconfig b/src/soc/intel/common/Kconfig index ac22686..523d1f5 100644 --- a/src/soc/intel/common/Kconfig +++ b/src/soc/intel/common/Kconfig @@ -68,4 +68,8 @@ Set this option to enable default debug interface of SoC such as DBC or DCI.
+config SMM_MODULE_STACK_SIZE + hex + default 0x800 + endif # SOC_INTEL_COMMON
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33999 )
Change subject: soc/intel/common: Increase SMM_MODULE_STACK stack to 0x800 ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33999/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33999/1//COMMIT_MSG@7 PS1, Line 7: stack size?
Hello Karthik Ramasubramanian, Paul Fagerburg, Tim Wawrzynczak, Shelley Chen, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33999
to look at the new patch set (#2).
Change subject: soc/intel/common: Increase SMM_MODULE_STACK_SIZE to 0x800 ......................................................................
soc/intel/common: Increase SMM_MODULE_STACK_SIZE to 0x800
While running the s0ix cycling test, we observed SMM Handler caused a stack overflow. This error happens during event log access.
This change is to increase the SMM_MODULE_STACK size to 0x800
BUG=b:135551854 TEST=suspend_resume test pass 500+ cycles, originally issue happenes within 150 cycle
Change-Id: Ib4686b4d2d4fc3976068779314f4ee15ef4a8ae2 Signed-off-by: Kane Chen kane.chen@intel.com --- M src/soc/intel/common/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/33999/2
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33999 )
Change subject: soc/intel/common: Increase SMM_MODULE_STACK_SIZE to 0x800 ......................................................................
Patch Set 2:
Patch Set 1: Code-Review+2
(1 comment)
done.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33999 )
Change subject: soc/intel/common: Increase SMM_MODULE_STACK_SIZE to 0x800 ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33999 )
Change subject: soc/intel/common: Increase SMM_MODULE_STACK_SIZE to 0x800 ......................................................................
Patch Set 2: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33999 )
Change subject: soc/intel/common: Increase SMM_MODULE_STACK_SIZE to 0x800 ......................................................................
Patch Set 3: Code-Review+2
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33999 )
Change subject: soc/intel/common: Increase SMM_MODULE_STACK_SIZE to 0x800 ......................................................................
soc/intel/common: Increase SMM_MODULE_STACK_SIZE to 0x800
While running the s0ix cycling test, we observed SMM Handler caused a stack overflow. This error happens during event log access.
This change is to increase the SMM_MODULE_STACK size to 0x800
BUG=b:135551854 TEST=suspend_resume test pass 500+ cycles, originally issue happenes within 150 cycle
Change-Id: Ib4686b4d2d4fc3976068779314f4ee15ef4a8ae2 Signed-off-by: Kane Chen kane.chen@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33999 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/common/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/soc/intel/common/Kconfig b/src/soc/intel/common/Kconfig index ac22686..523d1f5 100644 --- a/src/soc/intel/common/Kconfig +++ b/src/soc/intel/common/Kconfig @@ -68,4 +68,8 @@ Set this option to enable default debug interface of SoC such as DBC or DCI.
+config SMM_MODULE_STACK_SIZE + hex + default 0x800 + endif # SOC_INTEL_COMMON
-
Furquan Shaikh (Code Review) -
Kane Chen (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Paul Fagerburg (Code Review)
-
Tim Wawrzynczak (Code Review)