Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58062 )
Change subject: soc/intel/common/../cse: Avoid caching of CSE BAR ......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/58062/comment/fe36f75f_7f3261ab PS2, Line 69: void *
suggestion: return `uintptr_t` instead, arithemtic on a `void *` is illegal in C, see below.
Agreed as good practice.
Any thoughts about this ? 1. https://github.com/coreboot/coreboot/blob/master/src/arch/x86/include/arch/m...
2. https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...
https://review.coreboot.org/c/coreboot/+/58062/comment/f541e0b7_30288e70 PS2, Line 125: (get_cse_bar() + offset
Arithmetic on a `void *` is illegal in C although GCC allows it (maybe clang too?) […]
Ack