[XL] Change in coreboot[main]: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage

[Saurabh Mishra (Code Review)]

Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik.

Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83798?usp=email )

Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage
......................................................................

Patch Set 59:

(7 comments)

File src/soc/intel/pantherlake/acpi.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/4eeffe2d_cf3751a1?usp... :
PS59, Line 117: 	static acpi_cstate_t map[MAX(ARRAY_SIZE(cstate_set_s0ix),
              : 				ARRAY_SIZE(cstate_set_non_s0ix))] = { {0} };
> this is local variable and then declared as static. why you need to initialize it with zero ? […]

Sure, valid point. Removing the assigment.

https://review.coreboot.org/c/coreboot/+/83798/comment/486471d6_9446abc4?usp... :
PS59, Line 125: map
> why ? you should return NULL here and update the common code to handle the NULL code […]

Hi Subrata, will it also be requiring to make changes in other SOC platforms which are using generate_c_state_entries? Such as MTL, ADL, etc?

https://review.coreboot.org/c/coreboot/+/83798/comment/9245f003_cccd41d2?usp... :
PS59, Line 243: 		printk(BIOS_DEBUG, "DMAR engine1 ACPI added\n");
> please drop this. […]

Removed.

https://review.coreboot.org/c/coreboot/+/83798/comment/a461e5c2_88669723?usp... :
PS59, Line 257: 		printk(BIOS_DEBUG, "DMAR engine2 ACPI added\n");
> same

Removed.

https://review.coreboot.org/c/coreboot/+/83798/comment/3091abae_684b9153?usp... :
PS59, Line 274: 		printk(BIOS_DEBUG, "DMAR engine3 ACPI added\n");
> same

Removed.

https://review.coreboot.org/c/coreboot/+/83798/comment/91829baa_38913f29?usp... :
PS59, Line 291: 		printk(BIOS_DEBUG, "DMAR RMRR ACPI added\n");
> same

Removed.

https://review.coreboot.org/c/coreboot/+/83798/comment/90011289_cfea0280?usp... :
PS59, Line 305: 		printk(BIOS_DEBUG, "SATC ACPI added\n");
> same

Removed.