Attention is currently required from: Arthur Heymans.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63478 )
Change subject: cpu/x86/smm_module_load: Rewrite setup_stub
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63478/comment/59524865_dddc5460
PS4, Line 13: only later the parameters of the first stub where filled it. This
nit: s/where/were/, s/it/in/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42ef9d6a30f3039f25e2cde975086a1365ca4182
Gerrit-Change-Number: 63478
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 08 Apr 2022 04:18:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment