Attention is currently required from: Subrata Banik, Nick Vaccaro, Patrick Rudolph, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62737 )
Change subject: soc/intel/common: Pass `FSPM_UPD *` argument for spd functions
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/soc/intel/common/block/include/intelblocks/meminit.h:
https://review.coreboot.org/c/coreboot/+/62737/comment/37bb1a64_474da67b
PS2, Line 6: <fsp/util.h>
nit:
`<fsp/api.h>`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I770cfd05194c33e11f98f95c5b93157b0ead70c1
Gerrit-Change-Number: 62737
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 23:04:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment