Change in coreboot[master]: mb/google/hatch/variants/helios: Add DPTF control for ambient sensor
Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35447 )
Change subject: mb/google/hatch/variants/helios: Add DPTF control for ambient sensor ......................................................................
mb/google/hatch/variants/helios: Add DPTF control for ambient sensor
Add DPTF based thermal contorl for ambient sensor for CML based Helios system. Also, update other sensor names information.
BUG=139335207 BRANCH=None TEST=Build and Boot on Helios board.
Change-Id: I322d53536fbdf6db70f5a24afb322d9f206eaeac Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl 1 file changed, 22 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/35447/1
diff --git a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl index 9aa3928..e3159c8 100644 --- a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl @@ -22,7 +22,7 @@ #define DPTF_CPU_ACTIVE_AC4 75
#define DPTF_TSR0_SENSOR_ID 0 -#define DPTF_TSR0_SENSOR_NAME "Thermal Sensor 1" +#define DPTF_TSR0_SENSOR_NAME "Battery Charger" #define DPTF_TSR0_PASSIVE 65 #define DPTF_TSR0_CRITICAL 75 #define DPTF_TSR0_ACTIVE_AC0 50 @@ -33,7 +33,7 @@ #define DPTF_TSR0_ACTIVE_AC5 38
#define DPTF_TSR1_SENSOR_ID 1 -#define DPTF_TSR1_SENSOR_NAME "Thermal Sensor 2" +#define DPTF_TSR1_SENSOR_NAME "5V Regulator" #define DPTF_TSR1_PASSIVE 45 #define DPTF_TSR1_CRITICAL 65 #define DPTF_TSR1_ACTIVE_AC0 50 @@ -43,6 +43,17 @@ #define DPTF_TSR1_ACTIVE_AC4 40 #define DPTF_TSR1_ACTIVE_AC5 38
+#define DPTF_TSR2_SENSOR_ID 2 +#define DPTF_TSR2_SENSOR_NAME "Ambient" +#define DPTF_TSR2_PASSIVE 50 +#define DPTF_TSR2_CRITICAL 65 +#define DPTF_TSR2_ACTIVE_AC0 50 +#define DPTF_TSR2_ACTIVE_AC1 47 +#define DPTF_TSR2_ACTIVE_AC2 45 +#define DPTF_TSR2_ACTIVE_AC3 42 +#define DPTF_TSR2_ACTIVE_AC4 40 +#define DPTF_TSR2_ACTIVE_AC5 38 + #define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL
@@ -92,6 +103,10 @@ Package () { _SB.DPTF.TFN1, _SB.DPTF.TSR1, 100, 90, 69, 56, 46, 36, 30, 0, 0, 0, 0 + }, + Package () { + _SB.DPTF.TFN1, _SB.DPTF.TSR2, 100, 90, 69, 56, 46, 36, 30, 0, + 0, 0, 0 } })
@@ -99,11 +114,14 @@ /* CPU Throttle Effect on CPU */ Package () { _SB.PCI0.TCPU, _SB.PCI0.TCPU, 100, 60, 0, 0, 0, 0 },
- /* CPU Throttle Effect on Ambient (TSR0) */ + /* CPU Throttle Effect on TSR0 */ Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 },
- /* Charger Throttle Effect on Charger (TSR1) */ + /* Charger Throttle Effect on TSR1 */ Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR1, 100, 60, 0, 0, 0, 0 }, + + /* CPU Throttle Effect on TSR2 */ + Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR2, 100, 60, 0, 0, 0, 0 }, })
Name (MPPC, Package ()
Sumeet R Pawnikar has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/35447 )
Change subject: mb/google/hatch/variants/helios: Add DPTF control for ambient sensor ......................................................................
mb/google/hatch/variants/helios: Add DPTF control for ambient sensor
Add DPTF based thermal contorl for ambient sensor for CML based Helios system. Also, update other sensor names information.
BUG=b:139335207 BRANCH=None TEST=Build and Boot on Helios board.
Change-Id: I322d53536fbdf6db70f5a24afb322d9f206eaeac Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl 1 file changed, 22 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/35447/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35447 )
Change subject: mb/google/hatch/variants/helios: Add DPTF control for ambient sensor ......................................................................
Patch Set 2: Code-Review+2
Hello Ken Lu, Frank Chu, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35447
to look at the new patch set (#3).
Change subject: mb/google/hatch/variants/helios: Add DPTF control for ambient sensor ......................................................................
mb/google/hatch/variants/helios: Add DPTF control for ambient sensor
Add DPTF based thermal control for ambient sensor for CML based Helios system. Also, update other sensor names information.
BUG=b:139335207 BRANCH=None TEST=Build and Boot on Helios board and check all sensor details.
Change-Id: I322d53536fbdf6db70f5a24afb322d9f206eaeac Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl 1 file changed, 22 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/35447/3
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35447 )
Change subject: mb/google/hatch/variants/helios: Add DPTF control for ambient sensor ......................................................................
mb/google/hatch/variants/helios: Add DPTF control for ambient sensor
Add DPTF based thermal control for ambient sensor for CML based Helios system. Also, update other sensor names information.
BUG=b:139335207 BRANCH=None TEST=Build and Boot on Helios board and check all sensor details.
Change-Id: I322d53536fbdf6db70f5a24afb322d9f206eaeac Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35447 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl 1 file changed, 22 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl index 9aa3928..e3159c8 100644 --- a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl @@ -22,7 +22,7 @@ #define DPTF_CPU_ACTIVE_AC4 75
#define DPTF_TSR0_SENSOR_ID 0 -#define DPTF_TSR0_SENSOR_NAME "Thermal Sensor 1" +#define DPTF_TSR0_SENSOR_NAME "Battery Charger" #define DPTF_TSR0_PASSIVE 65 #define DPTF_TSR0_CRITICAL 75 #define DPTF_TSR0_ACTIVE_AC0 50 @@ -33,7 +33,7 @@ #define DPTF_TSR0_ACTIVE_AC5 38
#define DPTF_TSR1_SENSOR_ID 1 -#define DPTF_TSR1_SENSOR_NAME "Thermal Sensor 2" +#define DPTF_TSR1_SENSOR_NAME "5V Regulator" #define DPTF_TSR1_PASSIVE 45 #define DPTF_TSR1_CRITICAL 65 #define DPTF_TSR1_ACTIVE_AC0 50 @@ -43,6 +43,17 @@ #define DPTF_TSR1_ACTIVE_AC4 40 #define DPTF_TSR1_ACTIVE_AC5 38
+#define DPTF_TSR2_SENSOR_ID 2 +#define DPTF_TSR2_SENSOR_NAME "Ambient" +#define DPTF_TSR2_PASSIVE 50 +#define DPTF_TSR2_CRITICAL 65 +#define DPTF_TSR2_ACTIVE_AC0 50 +#define DPTF_TSR2_ACTIVE_AC1 47 +#define DPTF_TSR2_ACTIVE_AC2 45 +#define DPTF_TSR2_ACTIVE_AC3 42 +#define DPTF_TSR2_ACTIVE_AC4 40 +#define DPTF_TSR2_ACTIVE_AC5 38 + #define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL
@@ -92,6 +103,10 @@ Package () { _SB.DPTF.TFN1, _SB.DPTF.TSR1, 100, 90, 69, 56, 46, 36, 30, 0, 0, 0, 0 + }, + Package () { + _SB.DPTF.TFN1, _SB.DPTF.TSR2, 100, 90, 69, 56, 46, 36, 30, 0, + 0, 0, 0 } })
@@ -99,11 +114,14 @@ /* CPU Throttle Effect on CPU */ Package () { _SB.PCI0.TCPU, _SB.PCI0.TCPU, 100, 60, 0, 0, 0, 0 },
- /* CPU Throttle Effect on Ambient (TSR0) */ + /* CPU Throttle Effect on TSR0 */ Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 },
- /* Charger Throttle Effect on Charger (TSR1) */ + /* Charger Throttle Effect on TSR1 */ Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR1, 100, 60, 0, 0, 0, 0 }, + + /* CPU Throttle Effect on TSR2 */ + Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR2, 100, 60, 0, 0, 0, 0 }, })
Name (MPPC, Package ()
-
Furquan Shaikh (Code Review) -
Sumeet R Pawnikar (Code Review)