V Sowmya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41818 )
Change subject: mb/google/dedede: Enable the CSE Lite SKU for waddledoo ......................................................................
mb/google/dedede: Enable the CSE Lite SKU for waddledoo
This patch enables enables the CSE Lite SKU for the waddledoo board.
Change-Id: I24d7d715d55524807af0127aa4a346a008164b8c Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/google/dedede/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/41818/1
diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index 25ad61f..9f6cd52 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -12,6 +12,7 @@ select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_DA7219 select VARIANT_HAS_CAMERA_ACPI + select SOC_INTEL_CSE_LITE_SKU
config BOARD_GOOGLE_WADDLEDEE bool "Waddledee"
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41818 )
Change subject: mb/google/dedede: Enable the CSE Lite SKU for waddledoo ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41818/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41818/1//COMMIT_MSG@9 PS1, Line 9: enables nit: "enables" word is repeated.
Hello build bot (Jenkins), Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Balaji Manigandan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41818
to look at the new patch set (#2).
Change subject: mb/google/dedede: Enable the CSE Lite SKU for waddledoo ......................................................................
mb/google/dedede: Enable the CSE Lite SKU for waddledoo
This patch enables the CSE Lite SKU for the waddledoo board.
Change-Id: I24d7d715d55524807af0127aa4a346a008164b8c Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/google/dedede/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/41818/2
Krishna P Bhat D has uploaded a new patch set (#3) to the change originally created by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/41818 )
Change subject: mb/google/dedede: Enable the CSE Lite SKU for waddledoo ......................................................................
mb/google/dedede: Enable the CSE Lite SKU for waddledoo
This patch enables the CSE Lite SKU for the waddledoo board.
Change-Id: I24d7d715d55524807af0127aa4a346a008164b8c Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/google/dedede/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/41818/3
Hello build bot (Jenkins), Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Balaji Manigandan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41818
to look at the new patch set (#4).
Change subject: mb/google/dedede: Enable the CSE Lite SKU for dedede ......................................................................
mb/google/dedede: Enable the CSE Lite SKU for dedede
This patch enables the CSE Lite SKU for the dedede baseboard.
Change-Id: I24d7d715d55524807af0127aa4a346a008164b8c Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/google/dedede/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/41818/4
Hello build bot (Jenkins), Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Balaji Manigandan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41818
to look at the new patch set (#5).
Change subject: mb/google/dedede: Enable the CSE Lite SKU for dedede ......................................................................
mb/google/dedede: Enable the CSE Lite SKU for dedede
This patch enables the CSE Lite SKU for the dedede baseboard.
BUG=b:160201335 TEST=Build and boot waddledoo with CSE Lite SKU. Cq-Depend: chrome-internal:3142530
Change-Id: I24d7d715d55524807af0127aa4a346a008164b8c Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/google/dedede/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/41818/5
Hello build bot (Jenkins), Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Balaji Manigandan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41818
to look at the new patch set (#6).
Change subject: mb/google/dedede: Enable the CSE Lite SKU for dedede ......................................................................
mb/google/dedede: Enable the CSE Lite SKU for dedede
This patch enables the CSE Lite SKU for the dedede baseboard.
BUG=b:160201335 TEST=Build and boot waddledoo with CSE Lite SKU. Cq-Depend: chrome-internal:3142530
Change-Id: I24d7d715d55524807af0127aa4a346a008164b8c Signed-off-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/google/dedede/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/41818/6
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41818 )
Change subject: mb/google/dedede: Enable the CSE Lite SKU for dedede ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41818/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41818/1//COMMIT_MSG@9 PS1, Line 9: enables
nit: "enables" word is repeated.
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41818 )
Change subject: mb/google/dedede: Enable the CSE Lite SKU for dedede ......................................................................
Patch Set 6: Code-Review+2
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41818 )
Change subject: mb/google/dedede: Enable the CSE Lite SKU for dedede ......................................................................
Patch Set 6: Code-Review+2
Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41818 )
Change subject: mb/google/dedede: Enable the CSE Lite SKU for dedede ......................................................................
mb/google/dedede: Enable the CSE Lite SKU for dedede
This patch enables the CSE Lite SKU for the dedede baseboard.
BUG=b:160201335 TEST=Build and boot waddledoo with CSE Lite SKU. Cq-Depend: chrome-internal:3142530
Change-Id: I24d7d715d55524807af0127aa4a346a008164b8c Signed-off-by: V Sowmya v.sowmya@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41818 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Rizwan Qureshi rizwan.qureshi@intel.com --- M src/mainboard/google/dedede/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Rizwan Qureshi: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 0fc31e1..68282ea 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -20,6 +20,7 @@ select MAINBOARD_HAS_TPM2 select SOC_INTEL_JASPERLAKE select SOC_INTEL_COMMON_BLOCK_DTT + select SOC_INTEL_CSE_LITE_SKU
if BOARD_GOOGLE_BASEBOARD_DEDEDE
-
Karthik Ramasubramanian (Code Review) -
Krishna P Bhat D (Code Review)
-
Rizwan Qureshi (Code Review)
-
Sridhar Siricilla (Code Review)
-
V Sowmya (Code Review)