Attention is currently required from: Patrick Rudolph, Johnny Lin, Christian Walter, Shuming Chu (Shuming).
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71085 )
Change subject: soc/intel/xeon_sp: Improve FSP-S boottime for xeon-sp platform
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/xeon_sp/memmap.c:
https://review.coreboot.org/c/coreboot/+/71085/comment/1c4915a9_b15099fe
PS2, Line 34: * So set up MTRR to cover the full memory < 4G with WB.
from what I understand it only covers 0-TSEG, not the full memory < 4G. […]
Done
https://review.coreboot.org/c/coreboot/+/71085/comment/b62ada2f_31130be2
PS2, Line 41: /* Cache the TSEG region */
: if (CONFIG(TSEG_STAGE_CACHE))
: postcar_enable_tseg_cache(pcf);
This is included in the previous one.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71085
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib886eda81566b491325e8cd65c9dfb44c89977c7
Gerrit-Change-Number: 71085
Gerrit-PatchSet: 2
Gerrit-Owner: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Comment-Date: Fri, 14 Apr 2023 12:43:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment