Attention is currently required from: Felix Singer, Lance Zhao, Lean Sheng Tan, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76158?usp=email )
Change subject: acpi: Set checksum for SPCR table
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76158/comment/0be06c85_3d50242a :
PS1, Line 13: Fixes: commit 90464073e4a1 (acpi: Add SPCR table)
Odd enough that's a different log than I looked at before :D and this […]
Here's the log that mentions the checksum:
https://lava.9esec.io/scheduler/job/170839#results_9301823
```
[ 1.474906] ACPI BIOS Warning (bug): Incorrect checksum in table [SPCR] - 0x00, should be 0x8B (20190703/tbprint-173)
```
But the fwts errors seem unrelated and spurious (https://learn.microsoft.com/en-us/windows-hardware/drivers/serports/serial-p...).
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76158/comment/44a3b906_8e5f3a42 :
PS1, Line 1870: header->checksum = acpi_checksum((void *)spcr, header->length);
Doesn't `length` need to be adjusted too? […]
It's just one struct with a constant length.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76158?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0086a3e8c5b3a06da9edf40a7a288c534fc5a6b2
Gerrit-Change-Number: 76158
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 28 Jun 2023 18:48:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-MessageType: comment