Attention is currently required from: Furquan Shaikh, Subrata Banik, Nick Vaccaro, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51374 )
Change subject: soc/intel/common: Calculate and configure both SF Mask 1 and 2 ......................................................................
Patch Set 16:
(5 comments)
Patchset:
PS16: This patch is getting a little hairy... could it be split into updating SF mask 1 and SF mask 2?
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/51374/comment/36527aef_5ad99392 PS16, Line 70: User to select this Not really for the user is it? It should be selected by the SoCs that require it.
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/51374/comment/1c012858_b981afa7 PS16, Line 512: dataway data_ways
https://review.coreboot.org/c/coreboot/+/51374/comment/6d142ca0_6d1027b3 PS16, Line 523: dataway data_ways
https://review.coreboot.org/c/coreboot/+/51374/comment/cbfa5716_36b1a021 PS16, Line 531: mov %ebx, %eax /* restore dataway in eax */ : movl $0x02, %ecx : div %ecx WDYT about `shr` instead of `div`: ``` movl $0x01, %ecx shr %ebx, %cl ```
the value of `ebx` isn't required after this point (it's overwritten on line #541)