Attention is currently required from: Tarun Tuli, Michał Żygowski, Michał Kopeć, Krystian Hebel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69949 )
Change subject: soc/intel/alderlake: Hook up P2SB PCI ops
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/alderlake/chip.c:
https://review.coreboot.org/c/coreboot/+/69949/comment/d3134f5b_540200ce
PS5, Line 252: if (dev->path.type == DEVICE_PATH_DOMAIN)
: dev->ops = &pci_domain_ops;
: else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER)
: dev->ops = &cpu_bus_ops;
: else if (dev->path.type == DEVICE_PATH_PCI &&
: dev->path.pci.devfn == PCH_DEVFN_PMC)
: dev->ops = &pmc_ops;
: else if (dev->path.type == DEVICE_PATH_PCI &&
: dev->path.pci.devfn == PCH_DEVFN_P2SB)
: dev->ops = soc_p2sb_ops;
not directly related to this patch, but i'd recommend adding the device ops to the chipset devicetree file as ops instead of adding it during runtime
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69949
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c59441268676a8aab075abbc036e651b9426057
Gerrit-Change-Number: 69949
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Tue, 11 Apr 2023 16:34:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment