Attention is currently required from: Martin Roth, Tim Wawrzynczak, Amanda Hwang, Patrick Rudolph, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49338 )
Change subject: spd: Create new folder for SPD files
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/49338/comment/1c01268a_62ade552
PS4, Line 49: LP4X_SPD_SOURCE_PATH
One way to eliminate the manual effort for remembering the paths for SPD would be to incorporate tha […]
Once we combine the spd_tools for DDR4 and LP4x, I think we can make the "Path to SPD directory" optional and assume the fixed path ~/coreboot/spd/${MEMORY_TECHNOLOGY}/ since we will need MEMORY_TECHNOLOGY as an input anyways.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49338
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a871981642485020adaeaafd062f718c636a708
Gerrit-Change-Number: 49338
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 15 Jan 2021 20:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment