Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38439 )
Change subject: [WIP]soc/intel/tigerlake: Add asl support for USBC
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38439/2/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/usbc.asl:
PS2:
Did you write all the code from scratch?
https://review.coreboot.org/c/coreboot/+/38439/2/src/soc/intel/tigerlake/acp...
PS2, Line 23: // Replaces _SB.PCI0.IPC1
Use tabs.
https://review.coreboot.org/c/coreboot/+/38439/2/src/soc/intel/tigerlake/acp...
PS2, Line 192:
Remove blank lines at end of file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44fd726c14f96bd3c963f17ec8e0abc956a76ebd
Gerrit-Change-Number: 38439
Gerrit-PatchSet: 2
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jan 2020 11:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment