Attention is currently required from: Arthur Heymans, Michael Niewöhner.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80720?usp=email )
Change subject: mb/clevo/tgl-u: hda_verbs: correct vendor value comments
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Just my 2 cents, maybe the `/* vendor/linux: AZALIA_... */` comments are superfluous. As long as you provide the vendor values (which you do) you can decode these using the hda-decoder I wrote relatively easily.
File src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/80720/comment/c58b3b6c_c00f6d0c :
PS1, Line 54: vendor
linux.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80720?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I45b1d09d5a11b357ac2a20ef448ea642540cdc99
Gerrit-Change-Number: 80720
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sun, 25 Feb 2024 00:20:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment