Attention is currently required from: David Wu, Hou-hsun Lee, Alan Huang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59576 )
Change subject: mb/google/brya/var/brask: Set PL and PsysPL ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59576/comment/39b1153b_7854261f PS3, Line 9: Intel's spec Please mention the document name and revision, and even document the values in the commit message so reviewers can compare it with the code.
https://review.coreboot.org/c/coreboot/+/59576/comment/a5ac03f9_591bd53d PS3, Line 9: defalut default
https://review.coreboot.org/c/coreboot/+/59576/comment/f8e45b28_4ecc574d PS3, Line 10: Brask's spec Ditto.
https://review.coreboot.org/c/coreboot/+/59576/comment/bcc6d71b_8ef63aa3 PS3, Line 9: Set the defalut PL1, PL2 and PL4 according to Intel's spec. : Set PsysPL2 and PsysPmax according to Brask's spec. Please mark it up as a list, or reflow it for 75 characters per line.
File src/mainboard/google/brya/variants/brask/ramstage.c:
https://review.coreboot.org/c/coreboot/+/59576/comment/9d96dae1_a065f327 PS3, Line 13: { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, 15, 15000, 15000, 55000, 55000, 123000 }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_6, 15, 15000, 15000, 55000, 55000, 123000 }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, 28, 28000, 28000, 64000, 64000, 90000 }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 28, 28000, 28000, 64000, 64000, 140000 }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 45, 45000, 45000, 115000, 115000, 215000 }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_1, 45, 45000, 45000, 95000, 95000, 125000 }, Sort it the other way around?
https://review.coreboot.org/c/coreboot/+/59576/comment/532eb10c_9ff94621 PS3, Line 23: { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, 15, 135 }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_6, 15, 135 }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, 28, 230 }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 28, 230 }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 45, 230 }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_1, 45, 230 }, Ditto.
-
Paul Menzel (Code Review)