Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59370 )
Change subject: [WIP]soc/amd/mendocino: Add mendocino and mainboard ......................................................................
Patch Set 1:
(12 comments)
File src/soc/amd/mendocino/fsp_m_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/369a454c_40f0f634 PS1, Line 109: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/5dfc0fcf_4371d80c PS1, Line 122: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks
File src/soc/amd/mendocino/psp_verstage/svc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/0d6f1670_388d4d56 PS1, Line 6: #define SVC_CALL4(SVC_ID, R0, R1, R2, R3, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/3c0931ec_e0a71b3d PS1, Line 19: #define SVC_CALL3(SVC_ID, R0, R1, R2, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/d85160ca_6c958a96 PS1, Line 30: #define SVC_CALL2(SVC_ID, R0, R1, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/855e514f_828afa32 PS1, Line 40: #define SVC_CALL1(SVC_ID, R0, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/f37c190a_737282b5 PS1, Line 49: #define SVC_CALL0(SVC_ID, Ret) \ Macros with complex values should be enclosed in parentheses
File src/soc/amd/mendocino/root_complex.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/b09fd3f8_c2f7197a PS1, Line 72: * | | X86_RESET_VECTOR = BOOTBLOCK_END - 0x10 line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/060ed702_92590bb8 PS1, Line 75: * +--------------------------------+ BOOTBLOCK_ADDR = BOOTBLOCK_END - C_ENV_BOOTBLOCK_SIZE line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/85b1c271_13b0e7fd PS1, Line 80: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE + 0x200 line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/7120ea71_e84a6998 PS1, Line 82: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133538): https://review.coreboot.org/c/coreboot/+/59370/comment/f4faf3a1_347f837d PS1, Line 85: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE line over 96 characters
-
build bot (Jenkins) (Code Review)