Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83444?usp=email )
Change subject: soc/amd/common/root_complex: move IOHC_MMIO_EN definition to header ......................................................................
soc/amd/common/root_complex: move IOHC_MMIO_EN definition to header
To be able to use the IOHC_MMIO_EN define in other compilation units, move the define to the corresponding header file.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: If88950418406d1709ed95b3d05f7e6ad66438f95 Reviewed-on: https://review.coreboot.org/c/coreboot/+/83444 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martin.roth@amd.corp-partner.google.com Reviewed-by: Varshit Pandya pandyavarshit@gmail.com --- M src/soc/amd/common/block/include/amdblocks/root_complex.h M src/soc/amd/common/block/root_complex/non_pci_resources.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Varshit Pandya: Looks good to me, approved Martin Roth: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/root_complex.h b/src/soc/amd/common/block/include/amdblocks/root_complex.h index 767221e..9ef5d05 100644 --- a/src/soc/amd/common/block/include/amdblocks/root_complex.h +++ b/src/soc/amd/common/block/include/amdblocks/root_complex.h @@ -11,6 +11,8 @@ #define SMN_IOHC_MISC_BASE_13D1 0x13d10000 #define SMN_IOHC_MISC_BASE_13E1 0x13e10000
+#define IOHC_MMIO_EN BIT(0) + #define NON_PCI_RES_IDX_AUTO 0
struct non_pci_mmio_reg { diff --git a/src/soc/amd/common/block/root_complex/non_pci_resources.c b/src/soc/amd/common/block/root_complex/non_pci_resources.c index 54f3de2..1e2e235 100644 --- a/src/soc/amd/common/block/root_complex/non_pci_resources.c +++ b/src/soc/amd/common/block/root_complex/non_pci_resources.c @@ -5,8 +5,6 @@ #include <device/device.h> #include <types.h>
-#define IOHC_MMIO_EN BIT(0) - void read_non_pci_resources(struct device *domain, unsigned long *idx) { const uint32_t iohc_misc_base = get_iohc_misc_smn_base(domain);