Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50180 )
Change subject: arch/x86/smbios_defaults.c: Default to motherboard type
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/smbios_defaults.c:
https://review.coreboot.org/c/coreboot/+/50180/comment/933b288b_6b594465
PS1, Line 63: return SMBIOS_BOARD_TYPE_MOTHERBOARD;
Why? What's the improvement?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1419874a0ba3f2e21568fa4b07b88f2048d10203
Gerrit-Change-Number: 50180
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 04 Feb 2021 09:56:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment