Change in coreboot[master]: fix grub and tianocore make files

[Pim Bombeeck (Code Review)]

Pim Bombeeck has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34365 )

Change subject: fix grub and tianocore make files
......................................................................

fix grub and tianocore make files

Change-Id: I321d4abdc955a9f4bc4ee2f3d95ccbc020898d0a
Signed-off-by: Gompa 
---
M payloads/external/GRUB2/Makefile
M payloads/external/Makefile.inc
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/34365/1

diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile
index 43da597..b433bc0 100644
--- a/payloads/external/GRUB2/Makefile
+++ b/payloads/external/GRUB2/Makefile
@@ -28,7 +28,7 @@
    echo "    CONFIG     GRUB2 $(NAME-y)"
    rm -rf grub2/build
    mkdir grub2/build
-	cd grub2 && ./bootstrap.sh ; ./autogen.sh
+	cd grub2 && ./bootstrap ; ./autogen.sh
    cd grub2/build && ../configure CC="$(HOSTCC)" LD="$(LD)" \
    FREETYPE="pkg-config freetype2" BUILD_FREETYPE="pkg-config freetype2" \
    TARGET_CC="$(CC)" TARGET_OBJCOPY="$(OBJCOPY)" TARGET_STRIP="$(STRIP)" \
diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc
index 9c34efa..e38d4ed 100644
--- a/payloads/external/Makefile.inc
+++ b/payloads/external/Makefile.inc
@@ -125,7 +125,7 @@
 # Tianocore

payloads/external/tianocore/tianocore/Build/UEFIPAYLOAD.fd tianocore: $(DOTCONFIG)
-	$(MAKE) -C payloads/external/tianocore all \
+	$(MAKE) -C payloads/external/tianocore \
    	HOSTCC="$(HOSTCC)" \
    	CC="$(HOSTCC)" \
    	CONFIG_TIANOCORE_MASTER=$(CONFIG_TIANOCORE_MASTER) \

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34365 )

Change subject: fix grub and tianocore make files
......................................................................

Patch Set 1:

Thank you for fetching my mistake. Commits should be for independent changes, so I factored the GRUB change out into [1] with you as author and your Signed-off-by line.

Please amend this commit to be just for TianoCore, and explain in the commit message, why the `all` target is gone. (The commit hash can be changed in the Kconfig menu, so it should be compatible.)

[1]: https://review.coreboot.org/c/coreboot/+/34366

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34365 )

Change subject: fix grub and tianocore make files
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34365/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34365/1//COMMIT_MSG@7 
PS1, Line 7: fix grub and tianocore make files
Please prefix with "payloads/external:"

Maybe add a description of what was failing.  Why does the all target not work for tianocore?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34365 )

Change subject: fix grub and tianocore make files
......................................................................

Patch Set 1: Code-Review-1

What does this fix?

I don't think the sign-off is correct, either.

[Pim Bombeeck (Code Review)]

Pim Bombeeck has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34365 )

Change subject: fix grub and tianocore make files
......................................................................

Abandoned

cant reproduce