Attention is currently required from: Eric Lai, Felix Singer, Kangheui Won, Reka Norman, Simon Yang, Tarun Tuli.
Yunlong Jia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75872?usp=email )
Change subject: mb/google/nissa/var/gothrax: Add GPIO table for gothrax
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/brya/variants/gothrax/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/75872/comment/88d37965_d76cc10f :
PS4, Line 1: # SPDX-License-Identifier: GPL-2.0-only
Afaik coreboot doesn't use license headers for Makefiles anymore.
Done
File src/mainboard/google/brya/variants/gothrax/memory.c:
https://review.coreboot.org/c/coreboot/+/75872/comment/34b0cbab_aa12a4d3 :
PS4, Line 15: gpio_t spd_gpios[] = {
same like base board, no need.
OK, we have removed it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75872?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If852c7a30edb9fb778872414cb15dc3446aebc55
Gerrit-Change-Number: 75872
Gerrit-PatchSet: 6
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 21 Jun 2023 09:52:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment