Change in ...coreboot[master]: post: during post_code, only call elog when enabled

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Jett Rink (Code Review)

21 May 2019 21 May '19

12:53 p.m.

Jett Rink has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32914

Change subject: post: during post_code, only call elog when enabled ......................................................................

post: during post_code, only call elog when enabled

Now that we call post_code in other stages other than RAMSTAGE, we need to guard the elog calls with the appropriate condition in order to compile correctly.

Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Signed-off-by: Jett Rink jettrink@chromium.org --- M src/console/post.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/32914/1

diff --git a/src/console/post.c b/src/console/post.c index b17a819..28ebd0e 100644 --- a/src/console/post.c +++ b/src/console/post.c @@ -81,7 +81,7 @@ default: printk(BIOS_WARNING, "POST: Unexpected post code " "in previous boot: 0x%02x\n", code); -#if CONFIG(ELOG) +#if CONFIG(ELOG) && (CONFIG(ENV_RAMSTAGE) || CONFIG(ELOG_PRERAM)) elog_add_event_word(ELOG_TYPE_LAST_POST_CODE, code); #if CONFIG(CMOS_POST_EXTRA) if (extra)

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Jett Rink (Code Review)

21 May 21 May

12:54 p.m.

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

Patch Set 1:

I don't know how were got a +1 verified on the child CLs before this change

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 1 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Comment-Date: Tue, 21 May 2019 19:54:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

1:36 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32914/1/src/console/post.c File src/console/post.c:

https://review.coreboot.org/#/c/32914/1/src/console/post.c@84 PS1, Line 84: CONFIG( remove config here:

#if CONFIG(ELOG) && (ENV_RAMSTAGE || CONFIG(ELOG_PRERAM))

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 1 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 21 May 2019 20:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jett Rink (Code Review)

1:37 p.m.

Hello build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32914

to look at the new patch set (#2).

Change subject: post: during post_code, only call elog when enabled ......................................................................

post: during post_code, only call elog when enabled

Now that we call post_code in other stages other than RAMSTAGE, we need to guard the elog calls with the appropriate condition in order to compile correctly.

Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Signed-off-by: Jett Rink jettrink@chromium.org --- M src/console/post.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/32914/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 2 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Jett Rink (Code Review)

1:37 p.m.

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32914/1/src/console/post.c File src/console/post.c:

https://review.coreboot.org/#/c/32914/1/src/console/post.c@84 PS1, Line 84: CONFIG(

...

remove config here: […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 2 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 21 May 2019 20:37:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth martinroth@google.com Gerrit-MessageType: comment

Martin Roth (Code Review)

1:43 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32914/2/src/console/post.c File src/console/post.c:

https://review.coreboot.org/#/c/32914/2/src/console/post.c@84 PS2, Line 84: ENV_RAMSTAGE Actually, looking at it, I think this should be broader than just ramstage. what about:

#if CONFIG(ELOG) && (CONFIG(ELOG_PRERAM) || ! defined(__PRE_RAM__))

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 2 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 21 May 2019 20:43:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jett Rink (Code Review)

2:43 p.m.

Hello build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32914

to look at the new patch set (#3).

Change subject: post: during post_code, only call elog when enabled ......................................................................

post: during post_code, only call elog when enabled

Now that we call post_code in other stages other than RAMSTAGE, we need to guard the elog calls with the appropriate condition in order to compile correctly.

Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Signed-off-by: Jett Rink jettrink@chromium.org --- M src/console/post.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/32914/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 3 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

2:43 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/32914/3/src/console/post.c File src/console/post.c:

https://review.coreboot.org/#/c/32914/3/src/console/post.c@84 PS3, Line 84: #if CONFIG(ELOG) && (CONFIG(ELOG_PRERAM) || ! __PRE_RAM__ ) space prohibited after that '!' (ctx:WxW)

https://review.coreboot.org/#/c/32914/3/src/console/post.c@84 PS3, Line 84: #if CONFIG(ELOG) && (CONFIG(ELOG_PRERAM) || ! __PRE_RAM__ ) space prohibited before that close parenthesis ')'

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 3 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 21 May 2019 21:43:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jett Rink (Code Review)

2:44 p.m.

Hello build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32914

to look at the new patch set (#4).

Change subject: post: during post_code, only call elog when enabled ......................................................................

post: during post_code, only call elog when enabled

Now that we call post_code in other stages other than RAMSTAGE, we need to guard the elog calls with the appropriate condition in order to compile correctly.

Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Signed-off-by: Jett Rink jettrink@chromium.org --- M src/console/post.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/32914/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 4 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

2:44 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32914/4/src/console/post.c File src/console/post.c:

https://review.coreboot.org/#/c/32914/4/src/console/post.c@84 PS4, Line 84: #if CONFIG(ELOG) && (CONFIG(ELOG_PRERAM) || ! defined(__PRE_RAM__)) space prohibited after that '!' (ctx:WxW)

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 4 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 21 May 2019 21:44:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jett Rink (Code Review)

2:45 p.m.

Hello build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32914

to look at the new patch set (#5).

Change subject: post: during post_code, only call elog when enabled ......................................................................

post: during post_code, only call elog when enabled

Now that we call post_code in other stages other than RAMSTAGE, we need to guard the elog calls with the appropriate condition in order to compile correctly.

Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Signed-off-by: Jett Rink jettrink@chromium.org --- M src/console/post.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/32914/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 5 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Jett Rink (Code Review)

2:45 p.m.

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

Patch Set 5:

(1 comment)

Sorry for the patchset upload spam :(

https://review.coreboot.org/#/c/32914/2/src/console/post.c File src/console/post.c:

https://review.coreboot.org/#/c/32914/2/src/console/post.c@84 PS2, Line 84: ENV_RAMSTAGE

...

Actually, looking at it, I think this should be broader than just ramstage. what about: […]

I like that better, didn't know about the __PRE_RAM__

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 5 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 21 May 2019 21:45:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth martinroth@google.com Gerrit-MessageType: comment

Jett Rink (Code Review)

3:10 p.m.

Hello build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32914

to look at the new patch set (#6).

Change subject: post: during post_code, only call elog when enabled ......................................................................

post: during post_code, only call elog when enabled

Now that we call post_code in other stages other than RAMSTAGE, we need to guard the elog calls with the appropriate condition in order to compile correctly.

Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Signed-off-by: Jett Rink jettrink@chromium.org --- M src/console/post.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/32914/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 6 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Jett Rink (Code Review)

3:11 p.m.

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32914/2/src/console/post.c File src/console/post.c:

https://review.coreboot.org/#/c/32914/2/src/console/post.c@84 PS2, Line 84: ENV_RAMSTAGE

...

I like that better, didn't know about the __PRE_RAM__

It turns out that it too wide. I am mirroring how the elog.c file is included in is Makefile.inc

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 6 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 21 May 2019 22:11:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jett Rink jettrink@chromium.org Comment-In-Reply-To: Martin Roth martinroth@google.com Gerrit-MessageType: comment

Martin Roth (Code Review)

3:12 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32914/2/src/console/post.c File src/console/post.c:

https://review.coreboot.org/#/c/32914/2/src/console/post.c@84 PS2, Line 84: ENV_RAMSTAGE

...

It turns out that it too wide. I am mirroring how the elog.c file is included in is Makefile. […]

Sounds good. thanks for trying the suggestion.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 6 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 21 May 2019 22:12:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jett Rink jettrink@chromium.org Comment-In-Reply-To: Martin Roth martinroth@google.com Gerrit-MessageType: comment

Duncan Laurie (Code Review)

22 May 22 May

7:21 a.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 6 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 22 May 2019 14:21:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

7:21 a.m.

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32914 )

Change subject: post: during post_code, only call elog when enabled ......................................................................

post: during post_code, only call elog when enabled

Now that we call post_code in other stages other than RAMSTAGE, we need to guard the elog calls with the appropriate condition in order to compile correctly.

Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Signed-off-by: Jett Rink jettrink@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/32914 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/console/post.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved

diff --git a/src/console/post.c b/src/console/post.c index b17a819..0719e5e 100644 --- a/src/console/post.c +++ b/src/console/post.c @@ -81,7 +81,7 @@ default: printk(BIOS_WARNING, "POST: Unexpected post code " "in previous boot: 0x%02x\n", code); -#if CONFIG(ELOG) +#if CONFIG(ELOG) && (ENV_RAMSTAGE || CONFIG(ELOG_PRERAM)) elog_add_event_word(ELOG_TYPE_LAST_POST_CODE, code); #if CONFIG(CMOS_POST_EXTRA) if (extra)

-- To view, visit https://review.coreboot.org/c/coreboot/+/32914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0 Gerrit-Change-Number: 32914 Gerrit-PatchSet: 7 Gerrit-Owner: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2006

days inactive

2007

days old

coreboot-gerrit@coreboot.org

16 comments

4 participants

tags (0)

participants (4)

build bot (Jenkins) (Code Review)
Duncan Laurie (Code Review)
Jett Rink (Code Review)
Martin Roth (Code Review)