Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75420?usp=email )
Change subject: mb/starlabs/starbook: Fix the ramtop CMOS entry ......................................................................
mb/starlabs/starbook: Fix the ramtop CMOS entry
The ramtop entry has to be 10 bytes long, and it was incorrectly set to 10 bits, instead of 10 bytes. Change this to 80.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I506f9d98a389dd859038fd270c5e344b65f514f8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75420 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/starbook/cmos.layout M src/mainboard/starlabs/starbook/variants/tgl/cmos.layout 2 files changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/cmos.layout b/src/mainboard/starlabs/starbook/cmos.layout index d725d04..c15c6f8 100644 --- a/src/mainboard/starlabs/starbook/cmos.layout +++ b/src/mainboard/starlabs/starbook/cmos.layout @@ -8,6 +8,9 @@ 0 120 r 0 reserved_memory
# ----------------------------------------------------------------- +# coreboot config options: ramtop +304 80 h 0 ramtop + # RTC_BOOT_BYTE (coreboot hardcoded) 384 1 e 2 boot_option 388 4 h 0 reboot_counter @@ -44,9 +47,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-# coreboot config options: ramtop -1000 10 h 0 ramtop - # Bank: 2 # embedded controller settings (outside the checksummed area) 1024 8 h 1 fn_lock_state diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout index 589359f..b5a2fb7 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout +++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout @@ -8,6 +8,9 @@ 0 120 r 0 reserved_memory
# ----------------------------------------------------------------- +# coreboot config options: ramtop +304 80 h 0 ramtop + # RTC_BOOT_BYTE (coreboot hardcoded) 384 1 e 2 boot_option 388 4 h 0 reboot_counter @@ -44,9 +47,6 @@ # coreboot config options: check sums 984 16 h 0 check_sum
-# coreboot config options: ramtop -1000 10 h 0 ramtop - # Bank: 2 # embedded controller settings (outside the checksummed area) 1024 8 h 1 fn_lock_state