Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro.
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83481?usp=email )
Change subject: soc/intel/alderlake: Use common CAR API for cache reporting ......................................................................
soc/intel/alderlake: Use common CAR API for cache reporting
Replace the SoC-specific `report_cache_info()` function with the common `car_report_cache_info()` API from `car_lib`. This promotes code reuse and reduces SoC-specific implementation for cache reporting.
BUG=none TEST=Builds and boots successfully on google/marasov platform.
Change-Id: I18be2c33dbe5186643af52823eb2fb185a296909 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/alderlake/bootblock/report_platform.c 1 file changed, 2 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/83481/1
diff --git a/src/soc/intel/alderlake/bootblock/report_platform.c b/src/soc/intel/alderlake/bootblock/report_platform.c index cd4ac00..6372cd6 100644 --- a/src/soc/intel/alderlake/bootblock/report_platform.c +++ b/src/soc/intel/alderlake/bootblock/report_platform.c @@ -16,6 +16,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> +#include <intelblocks/car_lib.h> #include <soc/bootblock.h> #include <soc/pci_devs.h>
@@ -251,21 +252,6 @@ return pci_read_config16(dev, PCI_DEVICE_ID); }
-static void report_cache_info(void) -{ - int cache_level = CACHE_L3; - struct cpu_cache_info info; - - if (!fill_cpu_cache_info(cache_level, &info)) - return; - - printk(BIOS_INFO, "Cache: Level %d: ", cache_level); - printk(BIOS_INFO, "Associativity = %zd Partitions = %zd Line Size = %zd Sets = %zd\n", - info.num_ways, info.physical_partitions, info.line_size, info.num_sets); - - printk(BIOS_INFO, "Cache size = %zu MiB\n", get_cache_size(&info)/MiB); -} - static void report_cpu_info(void) { u32 i, cpu_id, cpu_feature_flag; @@ -297,7 +283,7 @@ "CPU: AES %ssupported, TXT %ssupported, VT %ssupported\n", mode[aes], mode[txt], mode[vt]);
- report_cache_info(); + car_report_cache_info(); }
static void report_mch_info(void)