Attention is currently required from: Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80174?usp=email )
Change subject: mb/google/brya/var/*: Use name 'LCD0' for internal panel output
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80174/comment/038c15d0_082a2423 :
PS2, Line 9: The GMA driver generates the brightness controls expecting the name
: LCD0
is anything additional needed here?
Acknowledged
Commit Message:
https://review.coreboot.org/c/coreboot/+/80174/comment/a0f16d49_7800fa8b :
PS3, Line 13: TEST=build/boot Win11 on google/brya (redrix), verify brightness controls are functional.
Please wrap
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80174?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I389553b2ddc5b09d165229e2d8066cacf852b82c
Gerrit-Change-Number: 80174
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Won Chung
wonchung@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 13 Feb 2024 18:42:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment