Change in ...coreboot[master]: mediatek/mt8183: support SANDISK LPDDR4X DDR bootup

[huayang duan (Code Review)]

huayang duan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33838

Change subject: mediatek/mt8183: support SANDISK LPDDR4X DDR bootup
......................................................................

mediatek/mt8183: support SANDISK LPDDR4X DDR bootup

Support SANDISK SDADA4CR-128G EMCP LPDDR4X DDR

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on EMCP DRAM

Change-Id: I7de4c9a27282d3d00f51adf46dcb3d2f3984bfff
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
3 files changed, 43 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/33838/1

diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c
index 5931c79..202a75f6 100644
--- a/src/mainboard/google/kukui/sdram_configs.c
+++ b/src/mainboard/google/kukui/sdram_configs.c
@@ -23,6 +23,7 @@
    [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB",
    [3] = "sdram-lpddr4x-KMDP6001DA-B425-4GB",
    [5] = "sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB",
+	[7] = "sdram-lpddr4x-SDADA4CR-128G-4GB",
 };

static struct sdram_params params;
diff --git a/src/mainboard/google/kukui/sdram_params/Makefile.inc b/src/mainboard/google/kukui/sdram_params/Makefile.inc
index 77158a5..40e3641 100644
--- a/src/mainboard/google/kukui/sdram_params/Makefile.inc
+++ b/src/mainboard/google/kukui/sdram_params/Makefile.inc
@@ -3,6 +3,7 @@
 sdram-params += sdram-lpddr4x-MT53E1G32D4NQ-4GB
 sdram-params += sdram-lpddr4x-KMDP6001DA-B425-4GB
 sdram-params += sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB
+sdram-params += sdram-lpddr4x-SDADA4CR-128G-4GB

$(foreach params,$(sdram-params), \
    $(eval cbfs-files-y += $(params)) \
diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
new file mode 100755
index 0000000..61060d6
--- /dev/null
+++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
@@ -0,0 +1,41 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 MediaTek Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <soc/emi.h>
+
+struct sdram_params params = {
+	.impedance = {
+		[ODT_OFF] = {0x8, 0x7, 0x0, 0xF},
+		[ODT_ON] = {0x9, 0x9, 0x0, 0xE}
+	},
+	.wr_level = {
+		[CHANNEL_A] = { {0x1F, 0x1C}, {0x1C, 0x1B} },
+		[CHANNEL_B] = { {0x27, 0x28}, {0x23, 0x28} }
+	},
+	.cbt_cs = {
+		[CHANNEL_A] = {0x3, 0x3},
+		[CHANNEL_B] = {0x4, 0x6}
+	},
+	.cbt_mr12 = {
+		[CHANNEL_A] = {0x5C, 0x5A},
+		[CHANNEL_B] = {0x5C, 0x5A}
+	},
+	.emi_cona_val = 0xF053F154,
+	.emi_conh_val = 0x44440003,
+	.emi_conf_val = 0x00421000,
+	.chn_emi_cona_val = {0x0444F051, 0x0444F051},
+	.cbt_mode_extern = CBT_NORMAL_MODE,
+	.delay_cell_unit = 868,
+};

[huayang duan (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33838

to look at the new patch set (#2).

Change subject: mediatek/mt8183: support SANDISK LPDDR4X DDR bootup
......................................................................

mediatek/mt8183: support SANDISK LPDDR4X DDR bootup

Support SANDISK SDADA4CR-128G EMCP LPDDR4X DDR

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on EMCP DRAM

Change-Id: I7de4c9a27282d3d00f51adf46dcb3d2f3984bfff
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
3 files changed, 43 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/33838/2

Change in ...coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[huayang duan (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33838

to look at the new patch set (#3).

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

Support SANDISK SDADA4CR-128G, MICRON KMDP6001DA-B425 EMCP LPDDR4X DDR bootup

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on EMCP DRAM

Change-Id: I7de4c9a27282d3d00f51adf46dcb3d2f3984bfff
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B422-4GB.c
M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
5 files changed, 95 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/33838/3

Change in ...coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33838 )

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/33838/3/src/mainboard/google/kukui/sdram_con... 
File src/mainboard/google/kukui/sdram_configs.c:

https://review.coreboot.org/#/c/33838/3/src/mainboard/google/kukui/sdram_con... 
PS3, Line 25:         [4] = "sdram-lpddr4x-KMDP6001DA-B425-4GB",
code indent should use tabs where possible

https://review.coreboot.org/#/c/33838/3/src/mainboard/google/kukui/sdram_con... 
PS3, Line 25:         [4] = "sdram-lpddr4x-KMDP6001DA-B425-4GB",
please, no spaces at the start of a line

Change in ...coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[huayang duan (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33838

to look at the new patch set (#4).

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

Support SANDISK SDADA4CR-128G, MICRON KMDP6001DA-B425 EMCP LPDDR4X DDR bootup

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on EMCP DRAM

Change-Id: I7de4c9a27282d3d00f51adf46dcb3d2f3984bfff
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B422-4GB.c
M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
5 files changed, 95 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/33838/4

Change in coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[huayang duan (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33838

to look at the new patch set (#5).

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

Support SANDISK SDADA4CR-128G, SAMSUNG KMDP6001DA-B425, KMDV6001DA-B620
EMCP LPDDR4X DDR bootup.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on EMCP DRAM

Change-Id: I7de4c9a27282d3d00f51adf46dcb3d2f3984bfff
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDH6001DA-B422-4GB.c
M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
6 files changed, 138 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/33838/5

Change in coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[huayang duan (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33838

to look at the new patch set (#6).

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

Support SANDISK SDADA4CR-128G, SAMSUNG KMDP6001DA-B425, KMDV6001DA-B620
EMCP LPDDR4X DDR bootup.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on EMCP DRAM

Change-Id: I7de4c9a27282d3d00f51adf46dcb3d2f3984bfff
Signed-off-by: Huayang Duan 
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDH6001DA-B422-4GB.c
M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
6 files changed, 138 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/33838/6

Change in coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[Huayang Duan (Code Review)]

Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33838 )

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[Patrick Georgi (Code Review)]

Patrick Georgi has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/33838 )

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

Removed Code-Review+2 by Huayang Duan

Change in coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33838 )

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

Patch Set 6:

could we get someone who's not the author to review this?

Change in coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33838 )

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

Patch Set 6: Code-Review+2

@SJ/Huayang, please add hungte/youcheng/yupingso for mt8183 review.

@Patrick the mapping looks good to me (at least for what it labeled there).

Change in coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[SJ Huang (Code Review)]

SJ Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33838 )

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

Patch Set 6:
> Patch Set 6: Code-Review+2
>
> @SJ/Huayang, please add hungte/youcheng/yupingso for mt8183 review.
>
> @Patrick the mapping looks good to me (at least for what it labeled there).

@Hungte, okay.

Change in coreboot[master]: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33838 )

Change subject: mediatek/mt8183: support more EMCP LPDDR4X DDR bootup
......................................................................

mediatek/mt8183: support more EMCP LPDDR4X DDR bootup

Support SANDISK SDADA4CR-128G, SAMSUNG KMDP6001DA-B425, KMDV6001DA-B620
EMCP LPDDR4X DDR bootup.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on EMCP DRAM

Change-Id: I7de4c9a27282d3d00f51adf46dcb3d2f3984bfff
Signed-off-by: Huayang Duan 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33838
Tested-by: build bot (Jenkins) 
Reviewed-by: Hung-Te Lin 
---
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/kukui/sdram_params/Makefile.inc
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDH6001DA-B422-4GB.c
M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c
A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
6 files changed, 138 insertions(+), 9 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Hung-Te Lin: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c
index 5931c79..d8b3cc4 100644
--- a/src/mainboard/google/kukui/sdram_configs.c
+++ b/src/mainboard/google/kukui/sdram_configs.c
@@ -21,8 +21,11 @@
 static const char *const sdram_configs[] = {
    [1] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB",
    [2] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB",
-	[3] = "sdram-lpddr4x-KMDP6001DA-B425-4GB",
+	[3] = "sdram-lpddr4x-KMDH6001DA-B422-4GB",
+	[4] = "sdram-lpddr4x-KMDP6001DA-B425-4GB",
    [5] = "sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB",
+	[6] = "sdram-lpddr4x-KMDV6001DA-B620-4GB",
+	[7] = "sdram-lpddr4x-SDADA4CR-128G-4GB",
 };

static struct sdram_params params;
diff --git a/src/mainboard/google/kukui/sdram_params/Makefile.inc b/src/mainboard/google/kukui/sdram_params/Makefile.inc
index 77158a5..fbc505b 100644
--- a/src/mainboard/google/kukui/sdram_params/Makefile.inc
+++ b/src/mainboard/google/kukui/sdram_params/Makefile.inc
@@ -1,8 +1,11 @@
 sdram-params :=
 sdram-params += sdram-lpddr4x-H9HCNNNCPMALHR-4GB
 sdram-params += sdram-lpddr4x-MT53E1G32D4NQ-4GB
+sdram-params += sdram-lpddr4x-KMDH6001DA-B422-4GB
 sdram-params += sdram-lpddr4x-KMDP6001DA-B425-4GB
 sdram-params += sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB
+sdram-params += sdram-lpddr4x-KMDV6001DA-B620-4GB
+sdram-params += sdram-lpddr4x-SDADA4CR-128G-4GB

$(foreach params,$(sdram-params), \
    $(eval cbfs-files-y += $(params)) \
diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDH6001DA-B422-4GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDH6001DA-B422-4GB.c
new file mode 100644
index 0000000..1e0c362
--- /dev/null
+++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDH6001DA-B422-4GB.c
@@ -0,0 +1,41 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 MediaTek Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <soc/emi.h>
+
+struct sdram_params params = {
+	.impedance = {
+		[ODT_OFF] = {0x9, 0x7, 0x0, 0xF},
+		[ODT_ON] = {0xA, 0x9, 0x0, 0xE}
+	},
+	.wr_level = {
+		[CHANNEL_A] = { {0x21, 0x21}, {0x20, 0x20} },
+		[CHANNEL_B] = { {0x1E, 0x1F}, {0x1D, 0x1E} }
+	},
+	.cbt_cs = {
+		[CHANNEL_A] = {0x1, 0x1},
+		[CHANNEL_B] = {0x2, 0x2}
+	},
+	.cbt_mr12 = {
+		[CHANNEL_A] = {0x56, 0x56},
+		[CHANNEL_B] = {0x58, 0x5C}
+	},
+	.emi_cona_val = 0xF053F154,
+	.emi_conh_val = 0x44440003,
+	.emi_conf_val = 0x00421000,
+	.chn_emi_cona_val = {0x0444F051, 0x0444F051},
+	.cbt_mode_extern = CBT_NORMAL_MODE,
+	.delay_cell_unit = 868,
+};
diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c
index 1e0c362..12acc61 100644
--- a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c
+++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c
@@ -17,20 +17,20 @@

struct sdram_params params = {
    .impedance = {
-		[ODT_OFF] = {0x9, 0x7, 0x0, 0xF},
-		[ODT_ON] = {0xA, 0x9, 0x0, 0xE}
+		[ODT_OFF] = {0x7, 0x6, 0x0, 0xF},
+		[ODT_ON] = {0x8, 0x9, 0x0, 0xD}
    },
    .wr_level = {
-		[CHANNEL_A] = { {0x21, 0x21}, {0x20, 0x20} },
-		[CHANNEL_B] = { {0x1E, 0x1F}, {0x1D, 0x1E} }
+		[CHANNEL_A] = { {0x22, 0x21}, {0x20, 0x21} },
+		[CHANNEL_B] = { {0x23, 0x27}, {0x23, 0x27} }
    },
    .cbt_cs = {
-		[CHANNEL_A] = {0x1, 0x1},
-		[CHANNEL_B] = {0x2, 0x2}
+		[CHANNEL_A] = {0x0, 0x0},
+		[CHANNEL_B] = {0x6, 0x6}
    },
    .cbt_mr12 = {
-		[CHANNEL_A] = {0x56, 0x56},
-		[CHANNEL_B] = {0x58, 0x5C}
+		[CHANNEL_A] = {0x56, 0x5A},
+		[CHANNEL_B] = {0x58, 0x58}
    },
    .emi_cona_val = 0xF053F154,
    .emi_conh_val = 0x44440003,
diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c
new file mode 100644
index 0000000..8cc0d3d
--- /dev/null
+++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c
@@ -0,0 +1,41 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 MediaTek Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <soc/emi.h>
+
+struct sdram_params params = {
+	.impedance = {
+		[ODT_OFF] = {0x8, 0x7, 0x0, 0xF},
+		[ODT_ON] = {0x9, 0x9, 0x0, 0xD}
+	},
+	.wr_level = {
+		[CHANNEL_A] = { {0x21, 0x24}, {0x22, 0x24} },
+		[CHANNEL_B] = { {0x24, 0x28}, {0x22, 0x27} }
+	},
+	.cbt_cs = {
+		[CHANNEL_A] = {0xC, 0xC},
+		[CHANNEL_B] = {0xB, 0xB}
+	},
+	.cbt_mr12 = {
+		[CHANNEL_A] = {0x58, 0x58},
+		[CHANNEL_B] = {0x56, 0x56}
+	},
+	.emi_cona_val = 0xF053F154,
+	.emi_conh_val = 0x44440003,
+	.emi_conf_val = 0x00421000,
+	.chn_emi_cona_val = {0x0444F051, 0x0444F051},
+	.cbt_mode_extern = CBT_NORMAL_MODE,
+	.delay_cell_unit = 868,
+};
diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
new file mode 100644
index 0000000..61060d6
--- /dev/null
+++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c
@@ -0,0 +1,41 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 MediaTek Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <soc/emi.h>
+
+struct sdram_params params = {
+	.impedance = {
+		[ODT_OFF] = {0x8, 0x7, 0x0, 0xF},
+		[ODT_ON] = {0x9, 0x9, 0x0, 0xE}
+	},
+	.wr_level = {
+		[CHANNEL_A] = { {0x1F, 0x1C}, {0x1C, 0x1B} },
+		[CHANNEL_B] = { {0x27, 0x28}, {0x23, 0x28} }
+	},
+	.cbt_cs = {
+		[CHANNEL_A] = {0x3, 0x3},
+		[CHANNEL_B] = {0x4, 0x6}
+	},
+	.cbt_mr12 = {
+		[CHANNEL_A] = {0x5C, 0x5A},
+		[CHANNEL_B] = {0x5C, 0x5A}
+	},
+	.emi_cona_val = 0xF053F154,
+	.emi_conh_val = 0x44440003,
+	.emi_conf_val = 0x00421000,
+	.chn_emi_cona_val = {0x0444F051, 0x0444F051},
+	.cbt_mode_extern = CBT_NORMAL_MODE,
+	.delay_cell_unit = 868,
+};