Attention is currently required from: Martin L Roth, Jason Nien, Jon Murphy, Martin Roth.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72769 )
Change subject: mb/google/skyrim: Disable unused SPI ROM types ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72769/comment/71a2c780_08453196 PS3, Line 10: Excluding the unused ROM types shrinks ramstage by almost 4k. Nice!
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/72769/comment/b1b44236_1c315e36 PS3, Line 206: # Gigadevice is used on Whiterun as an alternative to Winbond : config SPI_FLASH_GIGADEVICE : default y : : # XMC chips used on Markarth as an alternative to Winbond : # These chips identify as ST Micro (Manufacturer ID: 0x20) : config SPI_FLASH_STMICRO : default y Can these be moved to `skyrim/Kconfig.name` and only enabled for the necessary boards? That would remove the need for the comments describing which boards actually need them.