Attention is currently required from: Patrick Rudolph, Johnny Lin, Paul Menzel, Tim Chu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71968 )
Change subject: mb/intel: add ArcherCity CRB support ......................................................................
Patch Set 9:
(25 comments)
File src/mainboard/intel/archercity_crb/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/ac0eef5c_71b1684d PS9, Line 15: #define PCR_DMI_LPCIOD 0x2770 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/e079b7c4_7dc9d382 PS9, Line 16: #define PCR_DMI_LPCIOE 0x2774 please, no space before tabs
File src/mainboard/intel/archercity_crb/include/sprsp_ac_iio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/29284efe_d6d5168b PS9, Line 9: #define CFG_UPD_PCIE_PORT(pexphide, slotimp, slotpsp) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/412ed611_d6017538 PS9, Line 11: .SLOTEIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/a40218b1_0dde649d PS9, Line 12: .SLOTHPCAP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/a589b150_ad878bdb PS9, Line 13: .SLOTHPSUP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/0e8d4591_9b6ff066 PS9, Line 14: .SLOTPIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/87abb4ab_c6a8e9cf PS9, Line 15: .SLOTAIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/6386f8a4_a95aabb4 PS9, Line 16: .SLOTMRLSP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/8a211fc5_a654693d PS9, Line 17: .SLOTPCP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/869573ea_26d93f9a PS9, Line 18: .SLOTABP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/a1800883_f3447739 PS9, Line 19: .SLOTIMP = slotimp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/86552e31_8e740d35 PS9, Line 20: .SLOTSPLS = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/95369ff7_8ce92247 PS9, Line 21: .SLOTSPLV = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/145e02aa_b38e1392 PS9, Line 22: .SLOTPSP = slotpsp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/153c04de_5ad77929 PS9, Line 23: .VppEnabled = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/74d33a36_addd7df5 PS9, Line 24: .VppPort = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/2454d325_5acd75d7 PS9, Line 25: .VppAddress = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/f9a3eff9_f54e6fd8 PS9, Line 26: .MuxAddress = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/93695fef_a357b1cb PS9, Line 27: .ChannelID = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/2e7c97ec_46208168 PS9, Line 28: .PciePortEnable = 1, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/418a6f66_30605ae3 PS9, Line 29: .PEXPHIDE = pexphide, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/1e291c7d_6fb8917f PS9, Line 30: .HidePEXPMenu = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/90d54bd8_227d83a1 PS9, Line 31: .PciePortOwnership = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169839): https://review.coreboot.org/c/coreboot/+/71968/comment/4aa454c0_785d59df PS9, Line 32: .RetimerConnectCount = 0, \ please, no space before tabs
-
build bot (Jenkins) (Code Review)