Attention is currently required from: Frank Wu, Jason Nien, Kangheui Won, Isaac Lee, Jon Murphy, Martin Roth.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68482 )
Change subject: mb/google/skyrim/var/frostflow: Update devicetree setting
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/skyrim/variants/frostflow/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68482/comment/ac4b74ac_8f58925e
PS3, Line 52: register "generic.probed" = "1"
Matt is working on getting rid of this in the kernel. Matt what is your take on this? Should we let this CL go and clean it up later or should we fix it here.
https://review.coreboot.org/c/coreboot/+/68482/comment/7bc4861a_19497ac6
PS3, Line 111: GPIO_24
I think the GPIO config in variants/baseboard/gpio.c should be updated to LEVEL_LOW to be consistent with the configuration here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68482
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia03962b0e01394ddcd4971cbe0172ef5bd913e15
Gerrit-Change-Number: 68482
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Chao Gui
chaogui@google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Thu, 20 Oct 2022 16:41:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment