Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik.
Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/85531?usp=email )
Change subject: soc/intel/pantherlake: Change child nodes count to 1
......................................................................
Patch Set 5:
(2 comments)
File src/soc/intel/pantherlake/crashlog.c:
https://review.coreboot.org/c/coreboot/+/85531/comment/b513f6aa_68bdf687?usp... :
PS4, Line 316: printk(BIOS_DEBUG, "cpu_crashlog_discovery_table buffer count: 0x%x\n",
: cpu_cl_disc_tab.header.fields.count);
what is the point of showing buffer count? earlier, it was linked here due to overriding […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/85531/comment/9ce8b081_04757d4f?usp... :
PS4, Line 319: u32 cur_offset = 0;
why we are changing this ? can still stays at line 318
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85531?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I209366d324c95b7a32afdcfb792c34d927a0508e
Gerrit-Change-Number: 85531
Gerrit-PatchSet: 5
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Sun, 15 Dec 2024 17:25:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com