Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19090 )
Change subject: nb/intel/gm45: Allow setting backlight pwm frequency from CBFS ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/19090/2/src/northbridge/intel/gm45/gma.c File src/northbridge/intel/gm45/gma.c:
Line 668: printk(BIOS_ERR, "gma: Error reading blc pwm from CBFS\n");
line too long
I'll adapt the codeflow so that there is less indentation.
Line 678: #define MINIMUM_BLC_PWM 50
seems very low
It is... maybe 100?
PS2, Line 745: (blc_pwm_cbfs >= MINIMUM_BLC_PWM) && (blc_pwm_cbfs < 0xffff)
Better check this before casting to `int`.
Since it is actually cast into an int just checking that the value is above the (positive) minimal should do it right, or is that shady (mis)use of casts?