Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79291?usp=email )
Change subject: soc/intel/meteorlake: Enable SSE2 accelerated RSA sign. verification
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS4:
unfortunately, I don't see any savings after picking this cl.
Are you sure you have the vboot repository up-to-date in your build environment ?
except this CL, all other Cls are now landed in downstream (including coreboot, vboot project). I have picked this CL and performed 20 cycles. I don't see 5ms savings in run to run variation.
I don't what to say because I do. What about the 505-506 interval ? Do you at least observe a saving with that patch ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79291?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I382e62a765dbf2027c4ac54d6eb19a9542a8c302
Gerrit-Change-Number: 79291
Gerrit-PatchSet: 10
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 29 Dec 2023 16:31:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment