Attention is currently required from: Jakub Czapiga, Julius Werner, Jérémy Compostella, Werner Zeh.
Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/79946?usp=email )
Change subject: region: Turn region_end() into an inclusive region_last()
......................................................................
Patch Set 7:
(1 comment)
File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/c/coreboot/+/79946/comment/e11a24cb_6bb53d42?usp... :
PS5, Line 127: return region_offset(r) + region_sz(r) - 1;
Well, in C the order doesn't matter (for unsigned operations), it would just […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79946?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4bd6eced638745b7e845504da74542e4220554a
Gerrit-Change-Number: 79946
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Sun, 16 Jun 2024 15:21:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jakub Czapiga
czapiga@google.com