Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36113 )
Change subject: soc/amd/picasso: Remove unused SATA configurations ......................................................................
soc/amd/picasso: Remove unused SATA configurations
Picasso's SATA controller operates only in AHCI mode. Remove the Kconfig symbols previously used to select between other possibilities.
Change-Id: Iaeb8b4a2540e976d2e7361faf8c6d261e60398fd Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/picasso/Kconfig 1 file changed, 0 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/36113/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index ce77f45..c5faecb 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -114,48 +114,6 @@ string "AMD public Key" default "3rdparty/blobs/soc/amd/picasso/PSP/AmdPubKeyRV.bin"
-config PICASSO_SATA_MODE - int "SATA Mode" - default 0 - range 0 6 - help - Select the mode in which SATA should be driven. - The default is NATIVE. - 0: NATIVE mode does not require a ROM. - 2: AHCI may work with or without AHCI ROM. It depends on the payload support. - For example, seabios does not require the AHCI ROM. - 3: LEGACY IDE - 4: IDE to AHCI - 5: AHCI7804: ROM Required, and AMD driver required in the OS. - 6: IDE to AHCI7804: ROM Required, and AMD driver required in the OS. - -comment "NATIVE" - depends on PICASSO_SATA_MODE = 0 - -comment "AHCI" - depends on PICASSO_SATA_MODE = 2 - -comment "LEGACY IDE" - depends on PICASSO_SATA_MODE = 3 - -comment "IDE to AHCI" - depends on PICASSO_SATA_MODE = 4 - -comment "AHCI7804" - depends on PICASSO_SATA_MODE = 5 - -comment "IDE to AHCI7804" - depends on PICASSO_SATA_MODE = 6 - -if PICASSO_SATA_MODE = 2 || PICASSO_SATA_MODE = 5 - -config AHCI_ROM_ID - string "AHCI device PCI IDs" - default "1022,7801" if PICASSO_SATA_MODE = 2 - default "1022,7804" if PICASSO_SATA_MODE = 5 - -endif # PICASSO_SATA_MODE = 2 || PICASSO_SATA_MODE = 5 - config SERIRQ_CONTINUOUS_MODE bool default n
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36113 )
Change subject: soc/amd/picasso: Remove unused SATA configurations ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36113 )
Change subject: soc/amd/picasso: Remove unused SATA configurations ......................................................................
soc/amd/picasso: Remove unused SATA configurations
Picasso's SATA controller operates only in AHCI mode. Remove the Kconfig symbols previously used to select between other possibilities.
Change-Id: Iaeb8b4a2540e976d2e7361faf8c6d261e60398fd Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36113 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/soc/amd/picasso/Kconfig 1 file changed, 0 insertions(+), 42 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 9447fd7..33e8c81 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -136,48 +136,6 @@ string "AMD public Key" default "3rdparty/blobs/soc/amd/picasso/PSP/AmdPubKeyRV.bin"
-config PICASSO_SATA_MODE - int "SATA Mode" - default 0 - range 0 6 - help - Select the mode in which SATA should be driven. - The default is NATIVE. - 0: NATIVE mode does not require a ROM. - 2: AHCI may work with or without AHCI ROM. It depends on the payload support. - For example, seabios does not require the AHCI ROM. - 3: LEGACY IDE - 4: IDE to AHCI - 5: AHCI7804: ROM Required, and AMD driver required in the OS. - 6: IDE to AHCI7804: ROM Required, and AMD driver required in the OS. - -comment "NATIVE" - depends on PICASSO_SATA_MODE = 0 - -comment "AHCI" - depends on PICASSO_SATA_MODE = 2 - -comment "LEGACY IDE" - depends on PICASSO_SATA_MODE = 3 - -comment "IDE to AHCI" - depends on PICASSO_SATA_MODE = 4 - -comment "AHCI7804" - depends on PICASSO_SATA_MODE = 5 - -comment "IDE to AHCI7804" - depends on PICASSO_SATA_MODE = 6 - -if PICASSO_SATA_MODE = 2 || PICASSO_SATA_MODE = 5 - -config AHCI_ROM_ID - string "AHCI device PCI IDs" - default "1022,7801" if PICASSO_SATA_MODE = 2 - default "1022,7804" if PICASSO_SATA_MODE = 5 - -endif # PICASSO_SATA_MODE = 2 || PICASSO_SATA_MODE = 5 - config SERIRQ_CONTINUOUS_MODE bool default n
-
Marshall Dawson (Code Review) -
Martin Roth (Code Review)