Change in ...coreboot[master]: payloads/external/LinuxBoot: Update x86_64 defconfig

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33581

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

payloads/external/LinuxBoot: Update x86_64 defconfig

Add more UART drivers and increase console count to 32.
Fixes non working console on APL Up2 board.

Change-Id: Ib5bd33531741e588ac7d5ff6a02b0482f6655ddf
Signed-off-by: Patrick Rudolph 
---
M payloads/external/LinuxBoot/x86_64/defconfig
1 file changed, 13 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/33581/1

diff --git a/payloads/external/LinuxBoot/x86_64/defconfig b/payloads/external/LinuxBoot/x86_64/defconfig
index 39ae162..08c8fc8 100644
--- a/payloads/external/LinuxBoot/x86_64/defconfig
+++ b/payloads/external/LinuxBoot/x86_64/defconfig
@@ -52,7 +52,7 @@
 # CONFIG_ZONE_DMA is not set
 # CONFIG_X86_MPPARSE is not set
 # CONFIG_X86_EXTENDED_PLATFORM is not set
-CONFIG_IOSF_MBI=y
+CONFIG_X86_INTEL_LPSS=y
 # CONFIG_SCHED_OMIT_FRAME_POINTER is not set
 # CONFIG_DMI is not set
 CONFIG_PREEMPT=y
@@ -99,13 +99,18 @@
 CONFIG_MD=y
 CONFIG_BLK_DEV_DM=y
 CONFIG_DM_CRYPT=y
-CONFIG_SERIAL_8250_CONSOLE=y
-# CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set
-# CONFIG_SERIAL_8250_EXAR is not set
-# CONFIG_SERIAL_8250_LPSS is not set
-# CONFIG_SERIAL_8250_MID is not set
-# CONFIG_SERIAL_8250_PNP is not set
 CONFIG_SERIAL_8250=y
+# CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set
+# CONFIG_SERIAL_8250_PNP is not set
+CONFIG_SERIAL_8250_CONSOLE=y
+# CONFIG_SERIAL_8250_EXAR is not set
+CONFIG_SERIAL_8250_NR_UARTS=32
+CONFIG_SERIAL_8250_RUNTIME_UARTS=32
+CONFIG_SERIAL_8250_EXTENDED=y
+CONFIG_SERIAL_8250_MANY_PORTS=y
+CONFIG_SERIAL_8250_DW=y
+# CONFIG_SERIAL_8250_MID is not set
+CONFIG_SERIAL_DEV_BUS=y
 CONFIG_HW_RANDOM_TIMERIOMEM=y
 # CONFIG_HW_RANDOM_AMD is not set
 # CONFIG_HW_RANDOM_VIA is not set
@@ -115,6 +120,7 @@
 CONFIG_I2C=y
 CONFIG_POWER_SUPPLY=y
 # CONFIG_HWMON is not set
+CONFIG_MFD_INTEL_LPSS_PCI=y
 # CONFIG_VGA_ARB is not set
 CONFIG_FB=y
 CONFIG_FIRMWARE_EDID=y

[Patrick Rudolph (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33581

to look at the new patch set (#2).

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

payloads/external/LinuxBoot: Update x86_64 defconfig

* Add support for Linux 5.x
** Select PCI, which isn't the default anymore with 5.x
* Add support for Intel LPSS uart
** Select MFD and MFD_INTEL_LPSS_PCI
** Increase console count to 32
* Add support for coreboot framebuffer
** Select FB_SIMPLE
* Add support for eMMC/SDHCI
** Select MMC_SDHCI_*

Tested on Intel APL Up² board.
Fixes non working console on APL Up2 board and eMMC bootmedia shows up.

Change-Id: Ib5bd33531741e588ac7d5ff6a02b0482f6655ddf
Signed-off-by: Patrick Rudolph 
---
M payloads/external/LinuxBoot/x86_64/defconfig
1 file changed, 44 insertions(+), 44 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/33581/2

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33581 )

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

Patch Set 3: Code-Review+2

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33581 )

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

Patch Set 3: Code-Review+2

Out of interest: How large is the kernel with this config?

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33581 )

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

Patch Set 3: Code-Review-1

We want CONFIG_FIRMWARE_MEMMAP and CONFIG_KEXEC_FILE for the kexec feature.
Also /sys/firmware/log seems broken with provided defconfig.

Size:
vmlinuz 14MiB
payload 5MiB

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33581 )

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

Patch Set 3:

bzImage 1.8MiB

[Patrick Rudolph (Code Review)]

Hello Arthur Heymans, Christian Walter, Philipp Deppenwiese, Felix Singer, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33581

to look at the new patch set (#4).

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

payloads/external/LinuxBoot: Update x86_64 defconfig

* Add support for Linux 5.x
** Select PCI, which isn't the default anymore with 5.x
** Select google firmware driver, which wasn't build any more
* Add support for Intel LPSS uart
** Select MFD and MFD_INTEL_LPSS_PCI
** Increase console count to 32
* Add support for coreboot framebuffer
** Select FB_SIMPLE
* Add support for eMMC/SDHCI
** Select MMC_SDHCI_*
* Add support for u-root's localboot
** Select KEXEC_FILE_LOAD
** Select FIRMWARE_MEMMAP

Stats:
* Kernel size 1.9MiB
* U-root (core + systemboot) 4.6MiB

Tested on Intel APL Up² board:
* Fixes non working console on APL Up2 board and eMMC bootmedia shows up.
* Allows to boot GNU/Linux from eMMC using 'localboot'

Change-Id: Ib5bd33531741e588ac7d5ff6a02b0482f6655ddf
Signed-off-by: Patrick Rudolph 
---
M payloads/external/LinuxBoot/x86_64/defconfig
1 file changed, 48 insertions(+), 44 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/33581/4

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33581 )

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

Patch Set 4: Code-Review+1

(2 comments)

Why are the GCC plugins chosen?

https://review.coreboot.org/#/c/33581/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33581/4//COMMIT_MSG@14 
PS4, Line 14: ** Increase console count to 32
Why does it need to be increased?

https://review.coreboot.org/#/c/33581/4//COMMIT_MSG@28 
PS4, Line 28: bootmedia
boot media

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33581 )

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

Patch Set 4:

(1 comment)
> Patch Set 4: Code-Review+1
>
> (2 comments)
>
> Why are the GCC plugins chosen?

There's no change in GCC plugins. Some entries are reorder by Kconfig for unknown reason.

https://review.coreboot.org/#/c/33581/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33581/4//COMMIT_MSG@14 
PS4, Line 14: ** Increase console count to 32
> Why does it need to be increased?

It's required for LPSS uart. The first 4 are reserved for legacy UARTs and can't be used by MMIO32 uarts.

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33581 )

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

Patch Set 4: Code-Review+2

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33581 )

Change subject: payloads/external/LinuxBoot: Update x86_64 defconfig
......................................................................

payloads/external/LinuxBoot: Update x86_64 defconfig

* Add support for Linux 5.x
** Select PCI, which isn't the default anymore with 5.x
** Select google firmware driver, which wasn't build any more
* Add support for Intel LPSS uart
** Select MFD and MFD_INTEL_LPSS_PCI
** Increase console count to 32
* Add support for coreboot framebuffer
** Select FB_SIMPLE
* Add support for eMMC/SDHCI
** Select MMC_SDHCI_*
* Add support for u-root's localboot
** Select KEXEC_FILE_LOAD
** Select FIRMWARE_MEMMAP

Stats:
* Kernel size 1.9MiB
* U-root (core + systemboot) 4.6MiB

Tested on Intel APL Up² board:
* Fixes non working console on APL Up2 board and eMMC bootmedia shows up.
* Allows to boot GNU/Linux from eMMC using 'localboot'

Change-Id: Ib5bd33531741e588ac7d5ff6a02b0482f6655ddf
Signed-off-by: Patrick Rudolph 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33581
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Philipp Deppenwiese 
---
M payloads/external/LinuxBoot/x86_64/defconfig
1 file changed, 48 insertions(+), 44 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Philipp Deppenwiese: Looks good to me, approved

diff --git a/payloads/external/LinuxBoot/x86_64/defconfig b/payloads/external/LinuxBoot/x86_64/defconfig
index 39ae162..b28a80f 100644
--- a/payloads/external/LinuxBoot/x86_64/defconfig
+++ b/payloads/external/LinuxBoot/x86_64/defconfig
@@ -4,6 +4,7 @@
 CONFIG_SYSVIPC=y
 CONFIG_NO_HZ_IDLE=y
 CONFIG_HIGH_RES_TIMERS=y
+CONFIG_PREEMPT=y
 CONFIG_VIRT_CPU_ACCOUNTING_GEN=y
 CONFIG_CGROUPS=y
 CONFIG_MEMCG=y
@@ -36,36 +37,20 @@
 # CONFIG_COMPAT_BRK is not set
 CONFIG_SLOB=y
 # CONFIG_SLAB_MERGE_DEFAULT is not set
-CONFIG_GCC_PLUGINS=y
-CONFIG_GCC_PLUGIN_LATENT_ENTROPY=y
-CONFIG_GCC_PLUGIN_STRUCTLEAK=y
-CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL=y
-CONFIG_GCC_PLUGIN_RANDSTRUCT=y
-# CONFIG_VMAP_STACK is not set
-CONFIG_REFCOUNT_FULL=y
-# CONFIG_BLK_DEV_BSG is not set
-CONFIG_PARTITION_ADVANCED=y
-# CONFIG_IOSCHED_DEADLINE is not set
-# CONFIG_IOSCHED_CFQ is not set
-# CONFIG_MQ_IOSCHED_DEADLINE is not set
-# CONFIG_MQ_IOSCHED_KYBER is not set
 # CONFIG_ZONE_DMA is not set
 # CONFIG_X86_MPPARSE is not set
 # CONFIG_X86_EXTENDED_PLATFORM is not set
-CONFIG_IOSF_MBI=y
 # CONFIG_SCHED_OMIT_FRAME_POINTER is not set
 # CONFIG_DMI is not set
-CONFIG_PREEMPT=y
 # CONFIG_X86_MCE is not set
 # CONFIG_MICROCODE is not set
 CONFIG_X86_MSR=y
 CONFIG_X86_CPUID=y
-# CONFIG_SPARSEMEM_VMEMMAP is not set
-# CONFIG_COMPACTION is not set
 # CONFIG_MTRR is not set
 # CONFIG_X86_INTEL_UMIP is not set
 # CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS is not set
 CONFIG_KEXEC=y
+CONFIG_KEXEC_FILE=y
 # CONFIG_RELOCATABLE is not set
 # CONFIG_MODIFY_LDT_SYSCALL is not set
 # CONFIG_SUSPEND is not set
@@ -78,12 +63,30 @@
 # CONFIG_ACPI_TABLE_UPGRADE is not set
 # CONFIG_X86_PM_TIMER is not set
 # CONFIG_CPU_IDLE is not set
-CONFIG_PCIEPORTBUS=y
-CONFIG_PCIEASPM_POWER_SUPERSAVE=y
-CONFIG_PCI_MSI=y
 # CONFIG_ISA_DMA_API is not set
+CONFIG_GOOGLE_FIRMWARE=y
+CONFIG_GOOGLE_COREBOOT_TABLE=y
+CONFIG_GOOGLE_FRAMEBUFFER_COREBOOT=y
+CONFIG_GOOGLE_MEMCONSOLE_COREBOOT=y
+CONFIG_GOOGLE_VPD=y
+# CONFIG_VIRTUALIZATION is not set
+# CONFIG_VMAP_STACK is not set
+CONFIG_REFCOUNT_FULL=y
+CONFIG_GCC_PLUGINS=y
+CONFIG_GCC_PLUGIN_LATENT_ENTROPY=y
+CONFIG_GCC_PLUGIN_STRUCTLEAK=y
+CONFIG_GCC_PLUGIN_RANDSTRUCT=y
+# CONFIG_BLK_DEV_BSG is not set
+CONFIG_PARTITION_ADVANCED=y
+# CONFIG_MQ_IOSCHED_DEADLINE is not set
+# CONFIG_MQ_IOSCHED_KYBER is not set
 # CONFIG_BINFMT_SCRIPT is not set
 # CONFIG_COREDUMP is not set
+# CONFIG_SPARSEMEM_VMEMMAP is not set
+# CONFIG_COMPACTION is not set
+CONFIG_PCI=y
+CONFIG_PCIEPORTBUS=y
+CONFIG_PCI_MSI=y
 # CONFIG_UEVENT_HELPER is not set
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
@@ -92,35 +95,38 @@
 # CONFIG_ALLOW_DEV_COREDUMP is not set
 # CONFIG_PNP_DEBUG_MESSAGES is not set
 CONFIG_BLK_DEV_LOOP=y
+CONFIG_BLK_DEV_NVME=y
+CONFIG_NVME_MULTIPATH=y
 CONFIG_BLK_DEV_SD=y
 # CONFIG_SCSI_LOWLEVEL is not set
 CONFIG_ATA=y
-CONFIG_SATA_AHCI=y
 CONFIG_MD=y
 CONFIG_BLK_DEV_DM=y
 CONFIG_DM_CRYPT=y
-CONFIG_SERIAL_8250_CONSOLE=y
-# CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set
-# CONFIG_SERIAL_8250_EXAR is not set
-# CONFIG_SERIAL_8250_LPSS is not set
-# CONFIG_SERIAL_8250_MID is not set
-# CONFIG_SERIAL_8250_PNP is not set
 CONFIG_SERIAL_8250=y
+# CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set
+# CONFIG_SERIAL_8250_PNP is not set
+CONFIG_SERIAL_8250_CONSOLE=y
+CONFIG_SERIAL_8250_NR_UARTS=32
+CONFIG_SERIAL_8250_RUNTIME_UARTS=32
+CONFIG_SERIAL_8250_EXTENDED=y
+CONFIG_SERIAL_8250_MANY_PORTS=y
+CONFIG_SERIAL_8250_DW=y
+CONFIG_SERIAL_DEV_BUS=y
 CONFIG_HW_RANDOM_TIMERIOMEM=y
-# CONFIG_HW_RANDOM_AMD is not set
 # CONFIG_HW_RANDOM_VIA is not set
 CONFIG_TCG_TPM=y
 CONFIG_TCG_TIS=y
-# CONFIG_DEVPORT is not set
 CONFIG_I2C=y
 CONFIG_POWER_SUPPLY=y
 # CONFIG_HWMON is not set
-# CONFIG_VGA_ARB is not set
+CONFIG_MFD_INTEL_LPSS_PCI=y
 CONFIG_FB=y
 CONFIG_FIRMWARE_EDID=y
 CONFIG_FB_FOREIGN_ENDIAN=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_FB_TILEBLITTING=y
+CONFIG_FB_SIMPLE=y
 CONFIG_BACKLIGHT_LCD_SUPPORT=y
 CONFIG_VGACON_SOFT_SCROLLBACK=y
 CONFIG_VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y
@@ -128,14 +134,14 @@
 CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY=y
 CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=y
 # CONFIG_USB_SUPPORT is not set
+CONFIG_MMC=y
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_PCI=y
+CONFIG_MMC_SDHCI_ACPI=y
+CONFIG_MMC_SDHCI_PLTFM=y
 CONFIG_SYNC_FILE=y
 # CONFIG_VIRTIO_MENU is not set
 # CONFIG_X86_PLATFORM_DEVICES is not set
-# CONFIG_FIRMWARE_MEMMAP is not set
-CONFIG_GOOGLE_FIRMWARE=y
-CONFIG_GOOGLE_COREBOOT_TABLE_ACPI=y
-CONFIG_GOOGLE_MEMCONSOLE_COREBOOT=y
-CONFIG_GOOGLE_VPD=y
 CONFIG_EXT4_FS=y
 # CONFIG_FILE_LOCKING is not set
 # CONFIG_DNOTIFY is not set
@@ -149,7 +155,13 @@
 CONFIG_FAT_DEFAULT_UTF8=y
 CONFIG_TMPFS=y
 # CONFIG_MISC_FILESYSTEMS is not set
-# CONFIG_ENABLE_WARN_DEPRECATED is not set
+CONFIG_SECURITY_DMESG_RESTRICT=y
+CONFIG_FORTIFY_SOURCE=y
+# CONFIG_CRYPTO_ECHAINIV is not set
+CONFIG_CRYPTO_SHA256_SSSE3=y
+CONFIG_CRYPTO_ANSI_CPRNG=y
+CONFIG_CRYPTO_JITTERENTROPY=y
+# CONFIG_CRYPTO_HW is not set
 # CONFIG_ENABLE_MUST_CHECK is not set
 CONFIG_FRAME_WARN=1024
 # CONFIG_UNUSED_SYMBOLS is not set
@@ -163,11 +175,3 @@
 CONFIG_OPTIMIZE_INLINING=y
 # CONFIG_X86_DEBUG_FPU is not set
 CONFIG_UNWINDER_GUESS=y
-CONFIG_SECURITY_DMESG_RESTRICT=y
-CONFIG_FORTIFY_SOURCE=y
-# CONFIG_CRYPTO_ECHAINIV is not set
-CONFIG_CRYPTO_SHA256_SSSE3=y
-CONFIG_CRYPTO_ANSI_CPRNG=y
-CONFIG_CRYPTO_JITTERENTROPY=y
-# CONFIG_CRYPTO_HW is not set
-# CONFIG_VIRTUALIZATION is not set