Attention is currently required from: David Wu, Dinesh Gehlot, Nick Vaccaro, Rishika Raj.
Subrata Banik has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/83720?usp=email )
Change subject: mb/google/nissa/var/riven: Disable CNVi WIFI and BT based on fw_config
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/riven/fw_config.c:
https://review.coreboot.org/c/coreboot/+/83720/comment/6e4b7946_2fabdf23?usp... :
PS1, Line 70: if (!fw_config_probe(FW_CONFIG(WIFI_TYPE, WIFI_CNVI))) {
It will cause boot fail with "ASSERTION ERROR:file `src/soc/intel/alderlake/fsp_params.c`, line 820", seem like CB:83148.
When fw_config is unprovisioned (CNVi WIFI is disabled), CNVi BT must be turned off. Thanks.
What if FW config doesn't exist and we are coming here to probe?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83720?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icb925c02c73d3630be8b78debf608270b08854fe
Gerrit-Change-Number: 83720
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 04 Sep 2024 08:53:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Wu
david_wu@quanta.corp-partner.google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com