Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74523 )
Change subject: samsung/lumpy: Use APMC defines ......................................................................
samsung/lumpy: Use APMC defines
Change-Id: I658596da1d84b486126d751b6066c3efd3f65290 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/74523 Reviewed-by: Elyes Haouas ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/samsung/lumpy/smihandler.c 1 file changed, 16 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Elyes Haouas: Looks good to me, approved
diff --git a/src/mainboard/samsung/lumpy/smihandler.c b/src/mainboard/samsung/lumpy/smihandler.c index 1c7d626..50cfa47 100644 --- a/src/mainboard/samsung/lumpy/smihandler.c +++ b/src/mainboard/samsung/lumpy/smihandler.c @@ -47,12 +47,12 @@ ec_set_ports(EC_MAILBOX_PORT, EC_MAILBOX_PORT+1);
switch (apmc) { - case 0xe1: /* ACPI ENABLE */ + case APM_CNT_ACPI_ENABLE: send_ec_command(EC_SMI_DISABLE); send_ec_command(EC_ACPI_ENABLE); break;
- case 0x1e: /* ACPI DISABLE */ + case APM_CNT_ACPI_DISABLE: send_ec_command(EC_SMI_ENABLE); send_ec_command(EC_ACPI_DISABLE); break;