Attention is currently required from: Douglas Anderson, Paul Menzel, Bob Moragues, Julius Werner.
Mars Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62642 )
Change subject: mb/google/trogdor: Add variant Gelarshie
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62642/comment/7e380580_f2e9b53e
PS1, Line 7: Add new configs gelarshie
Add variant Gelarshie
Done
https://review.coreboot.org/c/coreboot/+/62642/comment/d93c60a8_a3b2a293
PS1, Line 9: boards
board
Done
File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/62642/comment/4a457885_418d5f5d
PS1, Line 10: TROGDOR_HAS_BRIDGE_BACKLIGHT
Actually, are you sure about setting this one to "Y"? I believe Homestar set this to `y` because it […]
Thanks for your review, Because display design of Gelarshie same as coachz , I had removed the line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62642
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie83df3c753d0863841430fe62805250ef8efeae9
Gerrit-Change-Number: 62642
Gerrit-PatchSet: 3
Gerrit-Owner: Mars Chen
chenxiangrui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Douglas Anderson
dianders@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Douglas Anderson
dianders@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 09 Mar 2022 03:56:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Douglas Anderson
dianders@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment