Attention is currently required from: Anand Vaikar, Bao Zheng, Maximilian Brune.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84373?usp=email )
Change subject: util/amdfwtool: Add binaries
......................................................................
Patch Set 5:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/84373/comment/517b99ae_d3aaebeb?usp... :
PS4, Line 649: fw_type = AMD_BIOS_NV_ST;
I can only say that it is a fairly big file (~300K), I don't know its actual contents.
oh, i've mixed up PSP_BDT_BIOS_NV_ST with AMD_FW_PSP_NVRAM and AMD_RPMC_NVRAM. checked the corresponding doc #55758 and it's not what i initially though it is. currently it might not be required, but again, not really sure about that one
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84373?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef
Gerrit-Change-Number: 84373
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Comment-Date: Wed, 30 Oct 2024 22:46:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de