Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Wonkyu Kim, Angel Pons, Bernardo Perez Priego, Srinidhi N Kaushik, Patrick Rudolph.
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50897 )
Change subject: soc/intel/tigerlake: Add CNVi Bluetooth flag at devicetree entry
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/50897/comment/d1ab117c_9a2de13c
PS6, Line 357: params->CnviBtCore = config->CnviBtCore;
Good point. This flag is added for tiger lake, let me check with FSP team. […]
Else part seems to be the default configuration when the device is not enabled. Is it better if we keep the else outside as default just before checking the device enabled and then when device is enabled we just overwrite those.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50897
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71c512fe884060e23ee26e7334c575c4c517b78d
Gerrit-Change-Number: 50897
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: AndreX Andraos
andrex.andraos@intel.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 01 Mar 2021 20:18:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment