Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56499 )
Change subject: mb/google/guybrush: Update GPIOs for fingerprint ......................................................................
Patch Set 6:
(6 comments)
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/56499/comment/b153a214_307448e1 PS2, Line 181:
Nit: Extra indentation.
Done
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/56499/comment/b8e7169a_f80b53dd PS6, Line 181: variant_finalize_gpios();
Nit: extra tab
Done
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/56499/comment/61014d24_a3d0d774 PS6, Line 69: /* EN_PWR_FP */
Nit: Retain that comment/Pin Info
Done
https://review.coreboot.org/c/coreboot/+/56499/comment/7dcc4be1_5611ebdf PS6, Line 358: /* : * If the system is not resuming from S3, power off the FPMCU : */
Nit: Single line comment.
Done
https://review.coreboot.org/c/coreboot/+/56499/comment/3641b33b_b67478b4 PS6, Line 373: /* FPMCU_RST_L */ : PAD_NC(GPIO_11), : /* EN_PWR_FP */ :
Nit: Extra tabs
Done
https://review.coreboot.org/c/coreboot/+/56499/comment/bf0a0228_4ee09ceb PS6, Line 386: gpio_set(GPIO_32, 1); /* EN_PWR_FP */ : mdelay(3);
Since the EN_PWR_FP is already set HIGH at the start of ramstage, do we still need to reset it and d […]
Good call, no we can get rid of this now.
Done.