Change in coreboot[master]: acpi: Add function to simplify If (CondRefOf (..)) sequences - coreboot-gerrit

8 Jul 2021


      Attention is currently required from: Cliff Huang, Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Karthik Ramasubramanian.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56003 )
Change subject: acpi: Add function to simplify If (CondRefOf (..)) sequences
......................................................................
Patch Set 2:
(1 comment)
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/56003/comment/77e4a725_3cb11a70 
PS1, Line 2255: acpigen_emit_byte(ZERO_OP); /* ignore COND_REFOF_OP destination */
...
This is required, COND_REFOF always takes 2 arguments, a namestring and then a destination for the r […]
Thanks,that make sense.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56003
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e192a569f550ecb77ad264275d52f219eacaca1
Gerrit-Change-Number: 56003
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 08 Jul 2021 02:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment