Attention is currently required from: Kyösti Mälkki, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55311 )
Change subject: sb,soc/intel: Use acpi_create_madt_ioapic_from_hw()
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/55311/comment/617808ae_92e721bd
PS10, Line 98: if (ioapic_entries) {
: for (int i = 0; i < ioapic_entries; i++) {
: current += acpi_create_madt_ioapic(
: (void *)current,
: ioapic_table[i].id,
: ioapic_table[i].addr,
: ioapic_table[i].gsi_base);
: }
: } else {
Note to self: the only uses xeon_sp code and it could really be improved.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55311
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9fd9cf230ce21674d1c24b40f310e5558e65be25
Gerrit-Change-Number: 55311
Gerrit-PatchSet: 10
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 10 Nov 2022 16:19:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment