Attention is currently required from: Nick Vaccaro, Subrata Banik.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80688?usp=email )
Change subject: soc/intel/alderlake: Add kconfig for Twin Lake
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/80688/comment/6ea1863d_d93de44c :
PS1, Line 113: and SOC_INTEL_ALDERLAKE_PCH_N together
not needed […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/80688/comment/ab0b2945_a1726e1c :
PS1, Line 406: alderlake_n
shouldn't this be `twinlake`
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80688?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie4c5d137ee54512313344f853e7ca66d1fd25003
Gerrit-Change-Number: 80688
Gerrit-PatchSet: 1
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 22 Feb 2024 09:14:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment